Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded 0.6x.x version numbers from main branch #944

Merged
merged 8 commits into from
Feb 7, 2022

Conversation

Saadnajmi
Copy link
Collaborator

This reverts commit 7100756.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

There are several places in the react native repo where the version number is hardcoded. On the *-stable branches, the version matches the actual version. On main/master, the version number is set to 1000.0.0 (To make it obvious the tip of the repo is not an official version of RN). At some point in one of our merges, we didn't revert the version number, meaning we were reporting we are still 0.63.3. Coincidentally, I'm pretty sure this is heavily related to why our circle-ci job fails.

Let's fix the version numbers back to 1000.0.0

Changelog

[Internal] [Fixed] - Set main branch version numbers back to 1000.0.0

Test Plan

@Saadnajmi Saadnajmi requested a review from alloy as a code owner January 9, 2022 09:45
@Saadnajmi Saadnajmi changed the title Remove hardcoded 0.63.3 version numbers from main Remove hardcoded 0.63.3 version numbers from main branch Jan 9, 2022
@Saadnajmi Saadnajmi mentioned this pull request Jan 9, 2022
4 tasks
@Saadnajmi Saadnajmi mentioned this pull request Jan 19, 2022
4 tasks
@Saadnajmi
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kelset
Copy link

kelset commented Feb 4, 2022

hey @Saadnajmi now that the main branch has merged back stuff from the 0.66 stable is this still needed? I think that if the answer is yes it'd be great to get it in soon :) I'm sure that a quick rebase then CI should be ✅ and we can 🚢 it :)

@Saadnajmi Saadnajmi requested review from mganandraj and a team as code owners February 4, 2022 16:42
@Saadnajmi Saadnajmi changed the title Remove hardcoded 0.63.3 version numbers from main branch Remove hardcoded 0.6x.x version numbers from main branch Feb 7, 2022
@Saadnajmi Saadnajmi merged commit cf2105f into microsoft:main Feb 7, 2022
@Saadnajmi Saadnajmi deleted the fix-ci branch February 7, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants