forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded 0.6x.x version numbers from main branch #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7100756.
Saadnajmi
changed the title
Remove hardcoded 0.63.3 version numbers from main
Remove hardcoded 0.63.3 version numbers from main branch
Jan 9, 2022
4 tasks
HeyImChris
approved these changes
Jan 10, 2022
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
HeyImChris
approved these changes
Jan 25, 2022
kelset
reviewed
Feb 1, 2022
hey @Saadnajmi now that the main branch has merged back stuff from the 0.66 stable is this still needed? I think that if the answer is yes it'd be great to get it in soon :) I'm sure that a quick rebase then CI should be ✅ and we can 🚢 it :) |
HeyImChris
approved these changes
Feb 4, 2022
Saadnajmi
changed the title
Remove hardcoded 0.63.3 version numbers from main branch
Remove hardcoded 0.6x.x version numbers from main branch
Feb 7, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7100756.
Please select one of the following
Summary
There are several places in the react native repo where the version number is hardcoded. On the
*-stable
branches, the version matches the actual version. Onmain/master
, the version number is set to1000.0.0
(To make it obvious the tip of the repo is not an official version of RN). At some point in one of our merges, we didn't revert the version number, meaning we were reporting we are still0.63.3
. Coincidentally, I'm pretty sure this is heavily related to why our circle-ci job fails.Let's fix the version numbers back to 1000.0.0
Changelog
[Internal] [Fixed] - Set main branch version numbers back to 1000.0.0
Test Plan