[CircleCI] E2E Tests fail

[Saadnajmi]

Environment

react-native -v:
npm ls react-native-macos:
node -v:
npm -v:
yarn --version:
xcodebuild -version:

Steps to reproduce the bug

This seems to be because the E2E tests are downloading react-native version 0.63 from NPM and testing against that, instead of using the local copy. #944 Might help with this, but I commented out the failing check in #945 . This bug is to track.

Expected Behavior

No response

Actual Behavior

No response

Reproducible Demo

No response

Additional context

No response

[HeyImChris]

Thanks for tracking the CI diff we have. Can leave this open until we resolve that in the CircleCI.

[kelset]

@Saadnajmi I think we can close this one, as far as I can tell it's fixed right? (at least on main the test is now uncommented again)

[Saadnajmi]

I only disabled the tests, I didn't fix them.

[kelset]

commit with the actual disabling of the test: https://github.com/microsoft/react-native-macos/pull/1052/files (posting for cross-reference)

[kelset]

update on this: I've investigated this problem a bit more with #1106. The long story short is that this is a problem that spawns from upstream, and that was only tackled in the react-native core repo in December 2021. So we'll only get access to the fixes when catching up to 0.68.

So basically we should not look into this problem until after react-native-macos has caught up to that. For some reason cherry-picking the specific commits don't address the issue on this repo so I'd imagine there's some other commit that is not directly related to the files I've been looking into; anyway it seems that it's not necessary to work further on this but just try to uncomment that CI block after we are on 68

[Saadnajmi]

Thanks for the update @kelset !

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.