Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing CircleCI test #1052

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Disable failing CircleCI test #1052

merged 2 commits into from
Feb 25, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This test never worked well, and I got tired of seeing red X's

Changelog

[Internal] [Changed] - Disabled failing CircleCI tests

Test Plan

@Saadnajmi Saadnajmi requested a review from a team as a code owner February 24, 2022 19:03
@Saadnajmi Saadnajmi changed the title [DrafT] Disable failing CircleCI test [Draft] Disable failing CircleCI test Feb 24, 2022
@Saadnajmi Saadnajmi changed the title [Draft] Disable failing CircleCI test Disable failing CircleCI test Feb 24, 2022
@Saadnajmi Saadnajmi merged commit 524b5ec into microsoft:main Feb 25, 2022
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Feb 27, 2022
@Saadnajmi
Disable failing CircleCI test (microsoft#1052)
bf5951c 
* Disable circleci test

* Disable another test
@Saadnajmi Saadnajmi mentioned this pull request Feb 27, 2022
Merged
Saadnajmi added a commit that referenced this pull request Feb 28, 2022
@Saadnajmi @sahrens
[0.66] Cherry pick Transforms fix and CI fix (#1058)
874bd4e 
* Fix transforms  (#1035)

* fix transforms #280

* remove duplicate

* fix errors

* Update from PR feedback

Co-authored-by: Spencer Ahrens <[email protected]>

* Disable failing CircleCI test (#1052)

* Disable circleci test

* Disable another test

Co-authored-by: Spencer Ahrens <[email protected]>
@Saadnajmi Saadnajmi deleted the disable-circleci branch June 24, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrieshin harrieshin harrieshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saadnajmi @harrieshin