Fix transforms #1035
Merged
Fix transforms #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
reviewed
Feb 25, 2022
harrieshin
reviewed
Feb 25, 2022
harrieshin
reviewed
Feb 25, 2022
harrieshin
approved these changes
Feb 25, 2022
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Feb 27, 2022
* fix transforms microsoft#280 * remove duplicate * fix errors * Update from PR feedback Co-authored-by: Spencer Ahrens <[email protected]>
|
@Saadnajmi We did some testing and this looks great, thank you. |
Thanks! It should be included in the next patch release of rn-macOS 0.66 =) |
Saadnajmi
added a commit
that referenced
this pull request
Feb 28, 2022
* Fix transforms (#1035) * fix transforms #280 * remove duplicate * fix errors * Update from PR feedback Co-authored-by: Spencer Ahrens <[email protected]> * Disable failing CircleCI test (#1052) * Disable circleci test * Disable another test Co-authored-by: Spencer Ahrens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This picks up where #280 and #460 left off, fixing animations on macOS.
Changelog
[macOS] [Fixed] - Fixed 3D Transforms not working properly
Test Plan
RN-Tester's transform page look identical on both iOS and macOS