CalculateTotalInputSizes/CalculateTotalOutputSizes bug #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
approved these changes
Jun 14, 2020
stevenlix
pushed a commit
that referenced
this pull request
Jun 14, 2020
stevenlix
added a commit
that referenced
this pull request
Jun 15, 2020
* Fix deprecated CentOS link for Linux CI pipeline (#4000) * Fix Linux_CI_GPU_Dev * centos6 * Fix crash reported in #4070. (#4091) * Fix crash reported in #4070. * Add newline to warning message * Add comment for using cout instead of the logger * fix optional input/outputs (#4229) Co-authored-by: Ryan Lai <[email protected]> Co-authored-by: Pranav Sharma <[email protected]> Co-authored-by: Tracy Sharpe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When profiling is enabled, these two functions are called to calculate the total size of the input and output tensors. The routines don't handle nodes with missing optional input or output nodes.
Motivation and Context
I hit a crash when attempting to run a model using python where profiling was enabled by default. The model had LSTM nodes with unused edges. This fix the crash.