Fix crash reported in #4070. #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
reviewed
May 30, 2020
edgchen1
reviewed
May 30, 2020
skottmckay
reviewed
Jun 1, 2020
skottmckay
previously approved these changes
Jun 1, 2020
stevenlix
pushed a commit
that referenced
this pull request
Jun 14, 2020
stevenlix
added a commit
that referenced
this pull request
Jun 15, 2020
* Fix deprecated CentOS link for Linux CI pipeline (#4000) * Fix Linux_CI_GPU_Dev * centos6 * Fix crash reported in #4070. (#4091) * Fix crash reported in #4070. * Add newline to warning message * Add comment for using cout instead of the logger * fix optional input/outputs (#4229) Co-authored-by: Ryan Lai <[email protected]> Co-authored-by: Pranav Sharma <[email protected]> Co-authored-by: Tracy Sharpe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix crash reported in #4070.
No logger is available when the session options APIs are used before creating an env. This went undetected in all our tests since we've a default logger setup in the test env and we always create the env before using any of the other APIs. I would've expected the issue to show up in this test. However, the C# tests are not run sequentially and a later test always ends up setting up the env and hence the default logger. Hence I added a test that does not rely on any test env.
I'm logging a message here and not returning an error to avoid breaking existing code. Ideally users should be able to upgrade ORT without changing their code.
Motivation and Context
Fixes issue #4070.