Add a comma to cgmanifest.json #15998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cgmanifest.json and generate_cgmanifest.py made too many trouble. should we enforce this in CI? |
pranavsharma
approved these changes
May 18, 2023
Good suggestion! I will find a way to do it. |
souptc
approved these changes
May 19, 2023
preetha-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 7, 2023
### Description In PR microsoft#15797, the author manually edited the cgmanifests/generated/cgmanifest.json file and made an error there that makes the file ill formed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #15797, the author manually edited the cgmanifests/generated/cgmanifest.json file and made an error there that makes the file ill formed.