Implement openAI endpoint invoker for nuget #15797

RandySheriffH · 2023-05-03T21:13:57Z

Implement openAI audio endpoint, and enable nuget packaging.

tools/ci_build/github/azure-pipelines/c-api-noopenmp-packaging-pipelines.yml

onnxruntime/core/framework/cloud_invoker.cc

pranavsharma

Please use RAII and make_unique (instead of malloc and free).

onnxruntime/core/framework/cloud_invoker.cc

tools/ci_build/github/azure-pipelines/c-api-noopenmp-packaging-pipelines.yml

onnxruntime/core/framework/cloud_invoker.cc

java/src/main/java/ai/onnxruntime/OrtProvider.java

RandySheriffH · 2023-05-04T16:56:56Z

Please use RAII and make_unique (instead of malloc and free).

RAll-ed two types:

Response buffer
Curl handles

onnxruntime/core/framework/cloud_invoker.cc

snnn · 2023-05-04T19:20:37Z

Run https://github.com/microsoft/onnxruntime/blob/main/cgmanifests/generate_cgmanifest.py.

Add the license of libcurl to https://github.com/microsoft/onnxruntime/blob/main/ThirdPartyNotices.txt since your public packages contains code from libcurl. Do this thing for all new dependencies this EP introduces, whether the dependency is a direct dependency or indirect dependency.

pranavsharma

LGTM

onnxruntime/core/framework/cloud_invoker.cc

RandySheriffH · 2023-05-11T00:09:24Z

Why cloud invoker has a function local static OrtDevice ?
static const OrtDevice cpu_device;
Why it needs be kept as a function local static?

Mind point to the code line of this?

snnn · 2023-05-11T00:34:44Z

Why cloud invoker has a function local static OrtDevice ?
static const OrtDevice cpu_device;
Why it needs be kept as a function local static?
Mind point to the code line of this?

Give me a moment. I'm searching it.

pranavsharma

LGTM 👍

onnxruntime/core/framework/cloud_invoker.cc

Implement openAI audio endpoint, and enable nuget packaging. --------- Co-authored-by: Randy Shuai <[email protected]>

### Description Revert a change in #15797: restore the correct version of emsdk ### Motivation and Context Without change, when you build it on Windows you will see: ``` 2023-05-17 19:41:30,093 build [INFO] - Activating emsdk... 2023-05-17 19:41:30,093 util.run [INFO] - Running subprocess in 'C:\src\onnxruntime2\cmake\external\emsdk' 'C:\src\onnxruntime2\cmake\external\emsdk\emsdk.bat' activate 3.1.37 error: tool or SDK not found: '3.1.37' ```

…15997) ### Description In PR #15797, the author manually edited the cgmanifests/generated/cgmanifest.json file and made an error that makes the file ill formed. ### Motivation and Context

### Description In PR #15797, the author manually edited the cgmanifests/generated/cgmanifest.json file and made an error there that makes the file ill formed.

### Description In PR microsoft#15797, the author manually edited the cgmanifests/generated/cgmanifest.json file and made an error there that makes the file ill formed.

implement openAi endpoint in nuget

a1feb54

RandySheriffH requested a review from a team as a code owner May 3, 2023 21:13

RandySheriffH added the release:1.15 label May 3, 2023

snnn reviewed May 3, 2023

View reviewed changes

tools/ci_build/github/azure-pipelines/c-api-noopenmp-packaging-pipelines.yml Show resolved Hide resolved

snnn reviewed May 3, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Show resolved Hide resolved

snnn reviewed May 3, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Outdated Show resolved Hide resolved

snnn reviewed May 3, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Outdated Show resolved Hide resolved

pranavsharma reviewed May 3, 2023

View reviewed changes

RandySheriffH commented May 3, 2023

View reviewed changes

make memory allocation RAII

dfc5461

Craigacp reviewed May 4, 2023

View reviewed changes

java/src/main/java/ai/onnxruntime/OrtProvider.java Show resolved Hide resolved

RandyShuai added 4 commits May 4, 2023 08:55

add curl to deps

8aaac2f

Merge branch 'main' into rashuai/AzureEP_1_15_nuget

6cdae88

wrap up curl handles

5c7c67c

set curl dep commit id

842f7fd

RandySheriffH changed the title ~~Implement openAi endpoint in nuget~~ Implement openAI endpoint invoker for nuget May 4, 2023

pranavsharma reviewed May 4, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Outdated Show resolved Hide resolved

onnxruntime/core/framework/cloud_invoker.cc Outdated Show resolved Hide resolved

onnxruntime/core/framework/cloud_invoker.cc Outdated Show resolved Hide resolved

pranavsharma reviewed May 4, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Outdated Show resolved Hide resolved

address comments

1fec44a

pranavsharma reviewed May 4, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Show resolved Hide resolved

RandyShuai added 2 commits May 4, 2023 17:07

write sized data to stream

a6f18e3

attach curl license

9c6bb2e

RandySheriffH requested a review from a team as a code owner May 5, 2023 00:31

pranavsharma reviewed May 5, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Show resolved Hide resolved

pranavsharma previously approved these changes May 5, 2023

View reviewed changes

merge main

7e14fd6

RandySheriffH dismissed pranavsharma’s stale review via 7e14fd6 May 9, 2023 16:04

merge main

c0e72cc

RandyShuai added 5 commits May 10, 2023 22:50

fix comments

ae7d534

fix header issue

7e51a9c

format code

fdad7c7

Merge branch 'main' of https://github.com/microsoft/onnxruntime

c013693

Merge branch 'main' into rashuai/AzureEP_1_15_nuget

e0dcb22

pranavsharma reviewed May 11, 2023

View reviewed changes

pranavsharma approved these changes May 11, 2023

View reviewed changes

pranavsharma previously approved these changes May 11, 2023

View reviewed changes

snnn reviewed May 11, 2023

View reviewed changes

onnxruntime/core/framework/cloud_invoker.cc Show resolved Hide resolved

clear fetch before emplace

866db7e

RandySheriffH dismissed pranavsharma’s stale review via 866db7e May 11, 2023 18:49

RandyShuai added 2 commits May 11, 2023 13:33

Merge branch 'main' of https://github.com/microsoft/onnxruntime

d099bd6

resolve conflict

17ae944

pranavsharma approved these changes May 12, 2023

View reviewed changes

snnn approved these changes May 12, 2023

View reviewed changes

RandySheriffH merged commit 7c4e826 into main May 12, 2023

RandySheriffH deleted the rashuai/AzureEP_1_15_nuget branch May 12, 2023 05:04

fs-eire pushed a commit that referenced this pull request May 12, 2023

Implement openAI endpoint invoker for nuget (#15797)

a916f41

Implement openAI audio endpoint, and enable nuget packaging. --------- Co-authored-by: Randy Shuai <[email protected]>

prathikr pushed a commit that referenced this pull request May 16, 2023

Implement openAI endpoint invoker for nuget (#15797)

898e440

Implement openAI audio endpoint, and enable nuget packaging. --------- Co-authored-by: Randy Shuai <[email protected]>

This was referenced May 18, 2023

Revert a change in #15797: restore the correct version of emsdk #15995

Merged

Update cgmanifest.json #15997

Merged

Add a comma to cgmanifest.json #15998

Merged

snnn removed the release:1.15 label May 18, 2023

snnn added a commit that referenced this pull request May 19, 2023

Add a comma to cgmanifest.json (#15998)

0f3aa9d

### Description In PR #15797, the author manually edited the cgmanifests/generated/cgmanifest.json file and made an error there that makes the file ill formed.

pranavsharma mentioned this pull request Jul 3, 2023

Support SmoothQuant for ORT static quantization #16288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement openAI endpoint invoker for nuget #15797

Implement openAI endpoint invoker for nuget #15797

RandySheriffH commented May 3, 2023

pranavsharma left a comment

RandySheriffH commented May 4, 2023

snnn commented May 4, 2023

pranavsharma left a comment

RandySheriffH commented May 11, 2023 •

edited

Loading

snnn commented May 11, 2023

pranavsharma left a comment

Implement openAI endpoint invoker for nuget #15797

Implement openAI endpoint invoker for nuget #15797

Conversation

RandySheriffH commented May 3, 2023

pranavsharma left a comment

Choose a reason for hiding this comment

RandySheriffH commented May 4, 2023

snnn commented May 4, 2023

pranavsharma left a comment

Choose a reason for hiding this comment

RandySheriffH commented May 11, 2023 • edited Loading

snnn commented May 11, 2023

pranavsharma left a comment

Choose a reason for hiding this comment

RandySheriffH commented May 11, 2023 •

edited

Loading