Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary logger should respect verbosity #4543

Open
KirillOsenkov opened this issue Jul 24, 2019 · 1 comment · Fixed by #8805
Open

Binary logger should respect verbosity #4543

KirillOsenkov opened this issue Jul 24, 2019 · 1 comment · Fixed by #8805
Labels
Area: Logging triaged
Milestone
Backlog

Comments

@KirillOsenkov
Copy link
Member

Currently the Binary Logger forces verbosity to diagnostic:
https://github.com/microsoft/msbuild/blob/bd233ed5dd20725c79b16d907634874237267d77/src/MSBuild/XMake.cs#L3043

This has side effects, such as forcing Log Task Inputs and DetailedSummary. We should probably respect the ambient verbosity if specified explicitly. Still default to diagnostic if /bl is specified and the verbosity isn't specified.
@rainersigwald rainersigwald added this to the Backlog milestone Nov 18, 2019
@KirillOsenkov KirillOsenkov mentioned this issue Apr 3, 2020
Open
@Forgind Forgind mentioned this issue May 26, 2023
Merged
JaynieBai pushed a commit that referenced this issue Jun 2, 2023
@Forgind
Change how verbosity is set (#8805)
5ca481b 
The binary logger, when turned on, sets the verbosity to diagnostic. This should not be true if the user explicitly requests another verbosity.

Fixes #4543
@rainersigwald
Copy link
Member

Reopening because we're reverting #8805 to fix #8845.

@rainersigwald rainersigwald reopened this Jun 6, 2023
@Forgind Forgind mentioned this issue Jun 7, 2023
Closed
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Logging triaged
Projects
None yet
Milestone
Backlog
3 participants
@KirillOsenkov @rainersigwald @AR-May