Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Binlog doesn't contain input parameters anymore #8845

Closed
rolfbjarne opened this issue Jun 6, 2023 · 1 comment · Fixed by #8846
Closed

[Bug]: Binlog doesn't contain input parameters anymore #8845

rolfbjarne opened this issue Jun 6, 2023 · 1 comment · Fixed by #8846

Comments

@rolfbjarne
Copy link
Member

Issue Description

It seems binlogs don't contain input parameters by default anymore.

Steps to Reproduce

  • Get a daily version of .NET (I'm using 8.0.100-preview.6.23305.2).
  • Create a new project
  • dotnet build /bl
$ dotnet new console
$ dotnet build /bl

Inspect the resulting binlog, noting that parameters are not there:

Screenshot 2023-06-06 at 12 50 46

Expected Behavior

Binlog should include every scrap of information it can.

Actual Behavior

Missing information from the binlog.

Analysis

This regressed somewhere between 8.0.100-preview.6.23279.5 and
8.0.100-preview.6.23305.2.

The dotnet/msbuild diff for that is: d077d29...9604d20

Looking at the commit list, I found one suspect:

#8805

And then it occurred to me to tried to explicitly pass the verbosity:

$ dotnet build /bl:msbuild-diagnostic.binlog /v:diag

And now the extra information is in the new binlog:

$ ls -la *.binlog
-rw-r--r--  1 rolf  wheel  379046 Jun  6 12:47 msbuild-diagnostic.binlog
-rw-r--r--  1 rolf  wheel  353999 Jun  6 12:43 msbuild.binlog

Note how the size is different.

Both binlogs: binlogs.zip

Versions & Configurations

$ 
dotnet --version
8.0.100-preview.6.23305.2
@rolfbjarne rolfbjarne added bug needs-triage Have yet to determine what bucket this goes in. labels Jun 6, 2023
@AR-May AR-May removed the needs-triage Have yet to determine what bucket this goes in. label Jun 6, 2023
rainersigwald added a commit that referenced this issue Jun 6, 2023
@rainersigwald
Copy link
Member

Thanks for the report and analysis, @rolfbjarne. Should be fixed in next SDK flow.

@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants