Bl should not stomp verbosity #8857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary logger, when turned on, sets the verbosity to diagnostic. This should not be true if the user explicitly requests another verbosity.
…ld-not-stomp-verbosity
JanKrivanek
approved these changes
Jun 8, 2023
Regardless of verbosity
Forgind
force-pushed
the
bl-should-not-stomp-verbosity
branch
from
31e1875
to
adce0f2
Compare
|
I intended to get back around to this but haven't for a while. Closing. If you think it's actually ready to go, and I should just resolve the conflict, let me know, and I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4543
The binary logger, when turned on, sets the verbosity to diagnostic. This should not be true if the user explicitly requests another verbosity.
This is based on #8805, but it was noticed that that disabled logging task parameters in the build. This is the same changes but reenables that if the BinaryLogger is present.