Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AcrylicBackgroundFillColorBaseBrush and AcrylicInAppFillColorBaseBrush #5177

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Update AcrylicBackgroundFillColorBaseBrush and AcrylicInAppFillColorBaseBrush #5177

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f4873a
update acrylic dark mode brush
karkarl Jun 11, 2021
7dad43a
append brush updates
karkarl Jun 11, 2021
10eb14c
changes from comments
karkarl Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev/Materials/Acrylic/AcrylicBrush_19h1_themeresources.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@
BackgroundSource="Backdrop"/>
<local:AcrylicBrush
x:Key="AcrylicBackgroundFillColorBaseBrush"
TintColor="#1C1C1C"
TintOpacity="0.75"
TintColor="#202020"
TintOpacity="0.5"
FallbackColor="#1C1C1C"
BackgroundSource="HostBackdrop"/>
<local:AcrylicBrush
x:Key="AcrylicInAppFillColorBaseBrush"
TintColor="#1C1C1C"
TintOpacity="0.75"
TintColor="#202020"
TintOpacity="0.5"
FallbackColor="#1C1C1C"
BackgroundSource="Backdrop"/>
<local:AcrylicBrush
Expand Down
8 changes: 4 additions & 4 deletions dev/Materials/Acrylic/AcrylicBrush_rs2_themeresources.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,14 +241,14 @@
BackgroundSource="Backdrop"/>
<local:AcrylicBrush
x:Key="AcrylicBackgroundFillColorBaseBrush"
TintColor="#1C1C1C"
TintOpacity="0.8"
TintColor="#202020"
TintOpacity="0.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave these as TintOpacity="0.8". In rs2 acrylic didn't have TintLuminosityOpacity so the TintOpacity has to be more opaque.

FallbackColor="#1C1C1C"
BackgroundSource="HostBackdrop"/>
<local:AcrylicBrush
x:Key="AcrylicInAppFillColorBaseBrush"
TintColor="#1C1C1C"
TintOpacity="0.8"
TintColor="#202020"
TintOpacity="0.5"
FallbackColor="#1C1C1C"
BackgroundSource="Backdrop"/>
<local:AcrylicBrush
Expand Down
4 changes: 2 additions & 2 deletions dev/dll/XamlControlsResources.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,11 @@ void XamlControlsResources::UpdateAcrylicBrushesDarkTheme(const winrt::IInspecta
}
if (const auto acrylicBackgroundFillColorBaseBrush = dictionary.Lookup(box_value(c_AcrylicBackgroundFillColorBaseBrush)).try_as<winrt::AcrylicBrush>())
{
acrylicBackgroundFillColorBaseBrush.TintLuminosityOpacity(0.92);
acrylicBackgroundFillColorBaseBrush.TintLuminosityOpacity(0.96);
}
if (const auto acrylicInAppFillColorBaseBrush = dictionary.Lookup(box_value(c_AcrylicInAppFillColorBaseBrush)).try_as<winrt::AcrylicBrush>())
{
acrylicInAppFillColorBaseBrush.TintLuminosityOpacity(0.92);
acrylicInAppFillColorBaseBrush.TintLuminosityOpacity(0.96);
}
if (const auto accentAcrylicBackgroundFillColorDefaultBrush = dictionary.Lookup(box_value(c_AccentAcrylicBackgroundFillColorDefaultBrush)).try_as<winrt::AcrylicBrush>())
{
Expand Down