Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AcrylicBackgroundFillColorBaseBrush and AcrylicInAppFillColorBaseBrush #5177

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Update AcrylicBackgroundFillColorBaseBrush and AcrylicInAppFillColorBaseBrush #5177

merged 3 commits into from
Jun 12, 2021

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented Jun 11, 2021

Description

Update AcrylicBackgroundFillColorBaseBrush and AcrylicInAppFillColorBaseBrush to match spec

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 11, 2021
@karkarl karkarl requested a review from marksfoster June 11, 2021 20:25
@karkarl
Copy link
Contributor Author

karkarl commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added area-Styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 11, 2021
@karkarl
Copy link
Contributor Author

karkarl commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

marksfoster
marksfoster reviewed Jun 11, 2021
View reviewed changes
dev/Materials/Acrylic/AcrylicBrush_rs2_themeresources.xaml Outdated
TintColor="#1C1C1C"
TintOpacity="0.8"
TintColor="#202020"
TintOpacity="0.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave these as TintOpacity="0.8". In rs2 acrylic didn't have TintLuminosityOpacity so the TintOpacity has to be more opaque.

@karkarl
Copy link
Contributor Author

karkarl commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit 3362d11 into main Jun 12, 2021
@ranjeshj ranjeshj deleted the user/karenlai/acrylicBrushUpdate branch June 12, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksfoster marksfoster marksfoster approved these changes

Assignees
No one assigned
Labels
area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karkarl @marksfoster @ranjeshj