Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox: Forward information to the inner TextBox for better UIA experience #3775

Merged

Conversation

marcelwgn
Copy link
Collaborator

Description

NumberBox now forwards header if its a string or the AutomationProperties.Name property if no header is present.

Motivation and Context

Closes #3505

How Has This Been Tested?

Add new API test

Screenshots (if appropriate):

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 5, 2020
@YuliKl YuliKl added area-NumberBox NumberBox Control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Dec 8, 2020
@ranjeshj ranjeshj added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Jan 6, 2021
@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dev/NumberBox/NumberBox.cpp Outdated Show resolved Hide resolved
dev/NumberBox/NumberBox.cpp Outdated Show resolved Hide resolved
dev/NumberBox/NumberBox.cpp Outdated Show resolved Hide resolved
dev/NumberBox/NumberBox.cpp Outdated Show resolved Hide resolved
dev/NumberBox/NumberBox.cpp Outdated Show resolved Hide resolved
dev/NumberBox/NumberBox.cpp Outdated Show resolved Hide resolved
dev/NumberBox/NumberBox.cpp Show resolved Hide resolved
dev/NumberBox/NumberBox.h Outdated Show resolved Hide resolved
dev/NumberBox/APITests/NumberBoxTests.cs Show resolved Hide resolved
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit a73a997 into microsoft:master Jan 19, 2021
@ranjeshj ranjeshj removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Jul 7, 2021
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 10, 2022
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 10, 2022
@marcelwgn marcelwgn deleted the user/chingucoding/numberbox-uia-forwarding branch January 13, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NumberBox NumberBox Control team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narrator fails to read the name for all the editable number boxes in "Number Box" page.
5 participants