-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preemptive caching #2944
Preemptive caching #2944
Conversation
Update upstream
Windows.Storage does not list shortcut files and hidden items |
Ok, so removing that is not an option |
And none of those work on recycle bin xD yeah it's complicated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakoss It seems like the NumberBox Header is skipped over by the screen reader, can you check that out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the ItemViewModel refactoring :)
An issue I'm seeing is that with this option enabled folder switching is sometimes delayed (I'll try to post a video). Is it just me?
It's no rush, thank you for the update. |
@yaichenbaum @gave92 I merged the changes from main branch, it was quite a ride after @hez2010 PR. But i think i got it right. Not sure about the end result after all. It does speed up things on my computer, but i have only nvme drives to test that on. And even on those the speedup is not really that mindblowing. Try it out on your machines. Also there are minor changes to I also made the adjustement to cache only the first 32 loaded items, since it's all we need to "visually" improve loading time. |
@jakoss I updated this PR with the latest changes from main. I hope I haven't screwed anything up. Small changes mostly to |
Co-authored-by: Yair Aichenbaum <[email protected]>
@jakoss Thank you! |
Adds preemptive caching to #1769
Fixes #3169
I had to do some refactoring to implement this feature. I had to make the "enumeration" functions more independent of
ItemViewModel
. I moved out some methods out of viewmodel, just for sake of readability and just to be a little more SOLID. I managed to lowerItemViewModel
line count by 200.There's one question from me. What is the reason to keep Win32 files enumeration along with Windows.Storage? I measured a little bit and i used application with only Windows.Storage enumeration and i didn't found significant performance difference. All gains from using direct C++ apis are minimal compared to other required operations in
EnumerateItemsFromStandardFolderAsync
. So i believe that using that introduces a lot of complicated and doubled logic without any real gain. @yaichenbaum @gave92 What do you think about that?I'll tackle the "double loading" issue in next Pull Request.