Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type descriptions for inherited types #2863

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Add type descriptions for inherited types #2863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e08c05
Add type descriptions for inherited types
papegaaij Jul 6, 2023
9c918a1
Merge branch 'main' into add-missing-descriptons
baywet Jul 10, 2023
1ec8bf4
Search through all sub schemas for a description
papegaaij Jul 10, 2023
4eb83db
- moves changelog entry to the next version
baywet Jul 10, 2023
c2689e3
Merge branch 'main' into add-missing-descriptons
baywet Jul 10, 2023
14d0d6d
Update src/Kiota.Builder/KiotaBuilder.cs
baywet Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Fixed missing type comments in many cases.
- Use schematized types for 206 response codes instead of binary. [#2880](https://github.com/microsoft/kiota/issues/2880)

## [1.4.0] - 2023-07-07
Expand Down
2 changes: 1 addition & 1 deletion src/Kiota.Builder/KiotaBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,7 @@ private CodeClass AddModelClass(OpenApiUrlTreeNode currentNode, OpenApiSchema sc
{
DocumentationLabel = schema.ExternalDocs?.Description ?? string.Empty,
DocumentationLink = schema.ExternalDocs?.Url,
Description = schema.Description.CleanupDescription(),
Description = (string.IsNullOrEmpty(schema.Description) ? schema.AllOf?.OrderBy(static x => x?.Reference?.Id, StringComparer.OrdinalIgnoreCase).LastOrDefault(static x => !string.IsNullOrEmpty(x.Description))?.Description : schema.Description).CleanupDescription(),
},
Deprecation = schema.GetDeprecationInformation(),
};
Expand Down