Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type descriptions for inherited types #2863

Merged
merged 6 commits into from
Jul 10, 2023

Conversation

papegaaij
Copy link
Contributor

These were often missing in the generated code. AddModelClass only looked in schema.Discription and not in the list of AllOf.

These were often missing in the generated code. AddModelClass only
looked in schema.Discription and not in the list of AllOf.
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always thanks for the contribution, one small improvement suggestion

src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes Jul 10, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

baywet
baywet previously approved these changes Jul 10, 2023
@baywet baywet enabled auto-merge July 10, 2023 14:11
baywet
baywet previously approved these changes Jul 10, 2023
@baywet baywet merged commit f30dba6 into microsoft:main Jul 10, 2023
@papegaaij papegaaij deleted the add-missing-descriptons branch July 10, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions are not always added to the source files
2 participants