Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsable interface split #1315

Merged
merged 10 commits into from
Mar 4, 2022
Merged

parsable interface split #1315

merged 10 commits into from
Mar 4, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Mar 2, 2022

fixes #737

Generation diff

microsoft/kiota-samples#544

TODO

CSharp

  • test with additional properties disabled
  • bump abstractions and serialization

Go

  • add new interface and update parsable
  • update refiner for new types
  • update parse node implementation
  • check the interface extraction code
  • test with additional properties disabled

Java

  • add new interface and update parsable
  • udpate refienr for new types
  • update parse node implementation
  • bump abstractions and serialization
  • test with additional properties disabled

TypeScript

  • add new interface and update parsable
  • update refiner for new types
  • update parse node implementation
  • bump abstractions and serialization
  • test with additional properties disabled

Global

  • add unit tests for usings/interfaces
  • update documentation
  • ping php and python teams
  • update ruby checklist

@baywet baywet added this to the Community Preview milestone Mar 2, 2022
@baywet baywet added generator Issues or improvements relater to generation capabilities. Go Csharp Pull requests that update .net code Java TypeScript Pull requests that update Javascript code labels Mar 2, 2022
@baywet baywet self-assigned this Mar 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

@andrueastman
Copy link
Member

@baywet
Just to confirm, do you usually have to update the go references after the merge since you need a ref to the merge commit?

* Gets the additional data for this object that did not belong to the properties.
* @return The additional data for this object.
*/
additionalData: Map<string, unknown>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could merge #1328 here. Using Record instead of Map

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and merge this PR, this way you can rebase #1328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsable interface should be splat
3 participants