New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split parsable interface in PHP #1324

Closed

6 tasks done

baywet opened this issue Mar 3, 2022 · 0 comments · Fixed by #1375

Closed

6 tasks done

split parsable interface in PHP #1324

baywet opened this issue Mar 3, 2022 · 0 comments · Fixed by #1375

Assignees

Labels

Milestone

Community Preview

Member

baywet commented Mar 3, 2022 •

edited by SilasKenneth

Loading

this is a reflection of #737 and #1315.

TODO:

introduce an additionalDataHolder interface next to parsable
move additional data members from parsable to the new interface
update json parse node to perform type assertion/cast adequately
update the refiner to correct the type name in the implements
update the refiner to add a using to that type when a model contains an additional data property
bump versions for abstractions and json

baywet added type:bug PHP labels

baywet added this to the Community Preview milestone

baywet assigned Ndiritu

SilasKenneth mentioned this issue

Split Parsable interface PHP #1375

Merged

SilasKenneth assigned SilasKenneth and unassigned Ndiritu

SilasKenneth closed this as completed in #1375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment