Update windowsbuilds.go #1155
Update windowsbuilds.go #1155
Conversation
|
/cc @kevpar Please help me with a CodeName for WS 2022 & the Windows 10 version that corresponds to this release so I can update the PR. Thank you :) |
osversion/windowsbuilds.go
Outdated
| @@ -35,4 +35,7 @@ const ( | |||
|
|
|||
| // V20H2 corresponds to Windows Server 20H2 (semi-annual channel). | |||
| V20H2 = 19042 | |||
|
|
|||
| // corresponds to Windows Server 2022 (ltsc2022), and Windows 10 (). | |||
There was a problem hiding this comment.
Start the comment with V2022 to satisfy godoc/go tooling. Wondering if we should name this V21H2 though
There was a problem hiding this comment.
I think V21H2 is reasonable given it's the version identifier used here: https://docs.microsoft.com/en-us/windows-server/get-started/windows-server-release-info
|
@adelina-t Thanks for this by the way! I was just mentioning I was going to add it yesterday 😂 |
adelina-t
force-pushed
the
patch-1
branch
2 times, most recently
from
e3caf99 to
83641ba
Compare
|
@adelina-t You're going to have to run |
|
@katiewasnothere Is the failure just because we need a rebase here? |
Might be. Let me try a rebase |
|
Yea, I'd try a rebase and go mod vendor + tidy again. |
Rebased & pushed, but no diff on mod vendor + tidy. Let's see though. |
|
@adelina-t What version of go are you on? Is it < 1.15? |
Updates windowsbuilds to include build number for Windows Server 2022. Signed-off-by: Adelina Tuvenie <[email protected]>
I've cherrypicked the commit on another machine, go mod + tidy & checked with |
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
Updates windowsbuilds to include build number for Windows Server 2022 and corresponding Windows 10 version.