-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process dump functionality for WCOW/LCOW #1062
Conversation
0b12030
to
e242b1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
313641f
to
dd93f38
Compare
@katiewasnothere Responded to feedback, ptal when you get another chance! |
@katiewasnothere Ping |
Once the windows sandbox mount PR is merged, we should add a test for it here and then I think we're good to merge. |
This commit adds support for generating process dumps for hypervisor isolated containers. This includes a new annotation to specify where process dumps should get placed on creation, which is global to all containers. Signed-off-by: Daniel Canter <[email protected]>
This change adds cri-containerd testcases that excercises the process dump functionality. It sets up two containers, using images that stackoverflow/ throw an exception shortly after starting. This should generate a dump file in the sandbox mount location in the test. Then the second container mounts the same sandbox mount and just verify that the core dump file generated by the first is present. Signed-off-by: Daniel Canter <[email protected]>
@katiewasnothere Checking in shortly now that the sandbox pr is in and a new test |
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
This commit adds support for generating process dumps for hypervisor isolated containers. This includes
a new annotation to specify where process dumps should get placed on creation, which is global
to all containers.
This was verified the following way through crictl:
Get a shell into the container and then grab the current pid (
echo $$
) and do akill -6 <pid>
. Re-exec in and there should be a file in /coredumps named something like "core.6.sh.176.1626339581". Then cp the file to /host and try out gdb on the file through wsl.gdb -c /mnt/c/Users/dcanter/desktop/coredump/core.6.sh.176.1626339581
Below is the Windows configs for this as well:
Afterwards there should a dmp at whatever the specified directory was. The container image is a slightly modified version of https://github.com/spreadex/win-docker-crash-dump. As we're setting wersvc to auto-start Stackoverflow exceptions work as well.
Signed-off-by: Daniel Canter [email protected]