IconNames: Deprecate due to const enum usage

[JasonGore]

Pull request checklist

• Addresses an existing issue: Fixes Ambient const enums are not allowed when the '--isolatedModules' flag is provided #7110, Fixes Ambient const enums are not allowed when the '--isolatedModules' flag is provided (Remove last const enum in IconNames.d.ts) #8003
• Include a change request file using $ npm run change

Description of changes

Per #7110 deprecate IconNames due to its usage of const enum.

Microsoft Reviewers: Open in CodeFlow

[msft-github-bot]

Hello @JasonGore!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

[size-auditor]

Size Auditor did not detect a change in bundle size for any component!

[dzearing]

Why is this deprecated? I don't think the type IconNamesInput would need to be deprecated.

Also, everything in the @uifabric/icons package is generated by the icon subsetting tool. You can talk with @Jahnp here, but we should change the tool first if we want to make any changes.

[JasonGore]

It is dependent on an deprecated object, and could also result in the issue people are seeing in #7110, so that is why I also marked this deprecated. Does that make sense?

I will talk to Peter about the tool, thanks.

[JasonGore]

More simply put maybe I should have just said it's a deprecated type, since it's keying off a deprecated object. 😄

[dzearing]

I believe @ThomasMichon added this. A better approach would be to keep the type, but just generate the type. adding this was a cheap way to get some type safety.

also, the tag should be @deprecated, not @deprecate.

[JasonGore]

I removed this change before the PR was merged.

[KevinTCoughlin]

Last I checked, SPFx was using string union type, but will double check. cc: @patmill

[JasonGore]

Spoke with @Jahnp and we may decide to close this PR and make another one from the upstream tool changes. I'll mark "Do not merge" for now and close/update within the next day or so.

[Jahnp]

@JasonGore and I chatted some more offline. This works great for now--we'll go ahead and deprecate the IconNames enum and plan to remove it for 7.0. We'll keep IconNamesInput, and in 7.0 replace it with a plan vs inferred string union.

[KevinTCoughlin]

Spoke with SPFx offline, signing-off

[msft-github-bot]

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release

[msft-github-bot]

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release
• Test the release with Developer Demo Site

[BTC-Bradley]

we'll go ahead and deprecate the IconNames enum and plan to remove it for 7.0.

@Jahnp, is there a road-map w/ ETA for the 7.0 release?

[Jahnp]

@BTC-Bradley project planning for 7.0 is early but actively being worked on. We're hoping to have it out within the next few months, but that's pending some investigations. You can track progress here (project is being built up & managed by @jdhuntington): https://github.com/OfficeDev/office-ui-fabric-react/projects/29