Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambient const enums are not allowed when the '--isolatedModules' flag is provided (Remove last const enum in IconNames.d.ts) #8003

Closed
BTC-Bradley opened this issue Feb 14, 2019 · 3 comments · Fixed by #8005

Comments

@BTC-Bradley
Copy link
Contributor

Hi Microsoft UI Fabric team,

This is a follow up to #7110 where @micahgodbolt mentioned opening a new issue to track the last use of const enums which is causing this error. The bug seems to have fallen through the cracks and I hope opening this new issue will help to resurface it and get it fixed.

Based on other discussions around this topic, I can see that @kenotron and others have spent a lot of time and effort in removing all the const enums from the library - this issue is to track removing the last remaining usage within IconNames.d.ts

Thanks,
Bradley

@JasonGore
Copy link
Member

We are considering IconNames to be deprecated with no easy path for resolving const enum usage and recommend using icon strings instead. I know #7110 hasn't had activity recently but this is technically a duplicate of that issue. I'll mark this one a duplicate, but in the meantime we're going to update #7110 to more clearly indicate overall const enum status. Thanks!

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #8005, which has now been successfully released as @uifabric/[email protected].:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #8005, which has now been successfully released as [email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants