Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(charts): Update V9 Charts to use DataVizGradientPalette #33323

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

feat(charts): Update V9 Charts to use DataVizGradientPalette #33323

wants to merge 20 commits into from
+2,560 −460

Conversation

shawn-grant
Copy link
Contributor

@shawn-grant shawn-grant commented Nov 21, 2024 •
edited
Loading

Implement DataVizGradientPalette and rounded corners in v9 charts as default

Modified

  • DonutChart
  • HorizontalBarChart

New Behavior (UI)

DonutChart

HorizontalBarChart

image

Notable Changes:

  • Added DataVizGradientPalette in utilities/gradients.ts
  • Replaced color properties with gradient in types/DataPoint.ts

New Usage

const data: ChartProps = {
  chartData: [
    {
      legend: 'first',
      data: 20000,
      // new `gradient` prop
      gradient: getGradientFromToken(DataVizGradientPalette.gradient1),
    },
    {
      legend: 'second',
      data: 39000,
      // custom gradient
      gradient: [ '#ff88cc', '#db3794' ],
    },
  ],
};

TODO

  • VerticalBarChart

Related

#32008

@shawn-grant
add gradient declarations
e5e79fc
@shawn-grant
replace color with gradient in ChartDataPoint and add gradient utilit…
b362372 
…y tests
@shawn-grant
refactor: update test-data.ts dataPoints to use gradient property
758f388
@shawn-grant
feat: implement gradient support in DonutChart components
09b1252
@shawn-grant
test: update DonutChart tests to use gradient instead of color
eef1cf2
@shawn-grant
feat: add gradient support to HorizontalBarChart and update rendering…
0c562b5 
… logic
@shawn-grant
refactor: replace color with gradient in HorizontalBarChart test cases
2eb7d67
@shawn-grant
build: update charts api readme
942d9a3
@shawn-grant
add update-snapshots script to package.json
d3cc0db
@shawn-grant
update tests and test snapshot
5d90039
@shawn-grant
Merge branch 'master' into chart-gradients
f64134a
@shawn-grant
refactor: update all DonutChart stories to use gradient pallete
d9aa34d
@shawn-grant
refactor: update HorizontalBarChart stories to use gradient palette
40f628c
@shawn-grant
Merge branch 'master' into chart-gradients
355faa6
@shawn-grant
fix HBC test snapshots
18988c5
@shawn-grant
update change files
61e5ad7
@shawn-grant shawn-grant marked this pull request as ready for review November 21, 2024 20:27
@shawn-grant shawn-grant requested a review from a team as a code owner November 21, 2024 20:27
@AtishayMsft
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions GitHub Actions
Copy link

📊 Bundle size report

✅ No changes found

@AtishayMsft
Copy link
Contributor

PR CI is failing.

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtishayMsft AtishayMsft AtishayMsft left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawn-grant @AtishayMsft