-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradient palette & rounded corners to Charting #32008
Merged
AtishayMsft
merged 80 commits into
microsoft:master
from
t-shawngrant:usr/t-shawngrant/charting-gradients
Aug 15, 2024
Merged
Add gradient palette & rounded corners to Charting #32008
AtishayMsft
merged 80 commits into
microsoft:master
from
t-shawngrant:usr/t-shawngrant/charting-gradients
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree company="Microsoft" |
…com/t-shawngrant/fluentui into usr/t-shawngrant/charting-gradients
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
📊 Bundle size report✅ No changes found |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
Commenter does not have sufficient privileges for PR 32008 in repo microsoft/fluentui |
/azp run |
Commenter does not have sufficient privileges for PR 32008 in repo microsoft/fluentui |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
🕵 fluentuiv8 No visual regressions between this PR and main |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
fabricteam
reviewed
Aug 15, 2024
change/@fluentui-react-charting-a3ef5de9-e169-4ae5-8380-461ba743a354.json
Show resolved
Hide resolved
AtishayMsft
reviewed
Aug 15, 2024
AtishayMsft
reviewed
Aug 15, 2024
...react-charting/src/components/HorizontalBarChartWithAxis/HorizontalBarChartWithAxis.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Aug 15, 2024
AtishayMsft
reviewed
Aug 15, 2024
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
🕵 fluentuiv8 No visual regressions between this PR and main |
AtishayMsft
approved these changes
Aug 15, 2024
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
fabricteam
reviewed
Aug 15, 2024
change/@fluentui-react-charting-a3ef5de9-e169-4ae5-8380-461ba743a354.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented Viva gradient color palette and rounded corners in charting
New color tokens
New chart props
Example Usage
New Behavior
charts will accept
enableGradient
androundCorners
boolean flags in their props.Donut Chart
Gauge Chart
Horizontal Bar Chart
Horizontal Bar Chart With Axis
Stacked Horizontal Bar Chart
Multi Stacked Bar Chart
Vertical Bar Chart
Vertical Stacked Bar Chart
Grouped Vertical Bar Chart
TODO