fix: Teaching bubble carousel tabs are visible in windows high contrast #31734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 647 | 622 | 5000 | |
| Button | mount | 304 | 298 | 5000 | |
| Field | mount | 1128 | 1136 | 5000 | |
| FluentProvider | mount | 722 | 720 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 30 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 85 | 86 | 10 | |
| MakeStyles | mount | 858 | 855 | 50000 | |
| Persona | mount | 1780 | 1754 | 5000 | |
| SpinButton | mount | 1410 | 1402 | 5000 | |
| SwatchPicker | mount | 1630 | 1672 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
Mitch-At-Work
approved these changes
Jun 17, 2024
fabricteam
reviewed
Jun 17, 2024
change/@fluentui-react-teaching-popover-cdaeeec1-2b74-432f-a6ec-694d78207d7c.json
Show resolved
Hide resolved
EdDaWord
pushed a commit
to EdDaWord/fluentui
that referenced
this pull request
Jun 17, 2024
EdDaWord
pushed a commit
to EdDaWord/fluentui
that referenced
this pull request
Aug 14, 2024
EdDaWord
pushed a commit
to EdDaWord/fluentui
that referenced
this pull request
Aug 16, 2024
EdDaWord
added a commit
that referenced
this pull request
Aug 19, 2024
Change most tokens in useButtonStyles file Give all the react-components a try chore(motion): add bundle size fixtures (#31730) fix(react-calendar-compat): fixed focus indicator cut off (#31596) feat: use custom states for button and anchor button variants (#31718) feat: update badge to use custom states (#31733) fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734) fix:react-nav-preview: High contrast issues (#31704) Pretty & lint & yarn change Somehow missed change files Fix one of the tests Fix React-text test
EdDaWord
added a commit
that referenced
this pull request
Aug 19, 2024
Change most tokens in useButtonStyles file Give all the react-components a try fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734) fix:react-nav-preview: High contrast issues (#31704) chore(motion): add bundle size fixtures (#31730) fix(react-calendar-compat): fixed focus indicator cut off (#31596) feat: use custom states for button and anchor button variants (#31718) docs: add min-width styles to Table and DataGrid stories, add best practices (#31721) fix:react-nav-preview: High contrast issues (#31704) Pretty & lint & yarn change Somehow missed change files Fix one of the tests Fix React-text test Use hashed name for each semantic and control token Build missed one Fix small mistake Fix small mistake Fix small mistake
EdDaWord
added a commit
that referenced
this pull request
Aug 19, 2024
Change most tokens in useButtonStyles file Give all the react-components a try fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734) fix:react-nav-preview: High contrast issues (#31704) chore(motion): add bundle size fixtures (#31730) fix(react-calendar-compat): fixed focus indicator cut off (#31596) feat: use custom states for button and anchor button variants (#31718) docs: add min-width styles to Table and DataGrid stories, add best practices (#31721) fix:react-nav-preview: High contrast issues (#31704) Pretty & lint & yarn change Somehow missed change files Fix one of the tests Fix React-text test Use hashed name for each semantic and control token Build missed one Fix small mistake Fix small mistake Fix small mistake Fix Random YML File
EdDaWord
added a commit
that referenced
this pull request
Aug 20, 2024
Change most tokens in useButtonStyles file Give all the react-components a try fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734) fix:react-nav-preview: High contrast issues (#31704) chore(motion): add bundle size fixtures (#31730) fix(react-calendar-compat): fixed focus indicator cut off (#31596) feat: use custom states for button and anchor button variants (#31718) docs: add min-width styles to Table and DataGrid stories, add best practices (#31721) fix:react-nav-preview: High contrast issues (#31704) Pretty & lint & yarn change Somehow missed change files Fix one of the tests Fix React-text test Use hashed name for each semantic and control token Build missed one Fix small mistake Fix small mistake Fix small mistake Fix Random YML File Fix rebase mistake
EdDaWord
added a commit
that referenced
this pull request
Aug 23, 2024
Change most tokens in useButtonStyles file Give all the react-components a try fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734) fix:react-nav-preview: High contrast issues (#31704) chore(motion): add bundle size fixtures (#31730) fix(react-calendar-compat): fixed focus indicator cut off (#31596) feat: use custom states for button and anchor button variants (#31718) docs: add min-width styles to Table and DataGrid stories, add best practices (#31721) fix:react-nav-preview: High contrast issues (#31704) Pretty & lint & yarn change Somehow missed change files Fix one of the tests Fix React-text test Use hashed name for each semantic and control token Build missed one Fix small mistake Fix small mistake Fix small mistake Fix Random YML File Fix rebase mistake Fix mistake on number of quotes Fix any possible merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The tabs/dots were not visible in WHCM:
New Behavior
Related Issue(s)