-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update badge to use custom states #31733
Merged
chrisdholt
merged 3 commits into
microsoft:master
from
chrisdholt:users/chhol/update-badge-to-use-custom-states
Jun 17, 2024
Merged
feat: update badge to use custom states #31733
chrisdholt
merged 3 commits into
microsoft:master
from
chrisdholt:users/chhol/update-badge-to-use-custom-states
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
chrisdholt
force-pushed
the
users/chhol/update-badge-to-use-custom-states
branch
from
June 17, 2024 19:25
9c39099
to
8eb23a9
Compare
fabricteam
reviewed
Jun 17, 2024
change/@fluentui-web-components-ff673af3-b066-47c9-aea7-37e4558d7ace.json
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/update-badge-to-use-custom-states
branch
from
June 17, 2024 19:53
69bc9b0
to
b7322d2
Compare
marchbox
approved these changes
Jun 17, 2024
davatron5000
approved these changes
Jun 17, 2024
EdDaWord
pushed a commit
to EdDaWord/fluentui
that referenced
this pull request
Jun 17, 2024
EdDaWord
pushed a commit
to EdDaWord/fluentui
that referenced
this pull request
Aug 16, 2024
EdDaWord
added a commit
that referenced
this pull request
Aug 19, 2024
Change most tokens in useButtonStyles file Give all the react-components a try chore(motion): add bundle size fixtures (#31730) fix(react-calendar-compat): fixed focus indicator cut off (#31596) feat: use custom states for button and anchor button variants (#31718) feat: update badge to use custom states (#31733) fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734) fix:react-nav-preview: High contrast issues (#31704) Pretty & lint & yarn change Somehow missed change files Fix one of the tests Fix React-text test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
All styles are associated with attribute selectors
New Behavior
Styles are associated with element internals custom states where supported and fallback to a state attribute when not supported.
Related Issue(s)