fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable #27650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve it undefined) when it is checkable.
khmakoto
added
Area: Accessibility
Component: ContextualMenu
Fluent UI react (v8)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd5e83e:
|
Asset size changes
Baseline commit: bb8dfe06f4f2910eef1561c76410bf91b009fa37 (build) |
📊 Bundle size report🤖 This report was generated against bb8dfe06f4f2910eef1561c76410bf91b009fa37 |
fabricteam
reviewed
Apr 20, 2023
smhigley
approved these changes
Apr 20, 2023
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 792 | 773 | 5000 | |
| Breadcrumb | mount | 2028 | 2032 | 1000 | |
| Checkbox | mount | 2083 | 2102 | 5000 | |
| CheckboxBase | mount | 1854 | 1857 | 5000 | |
| ChoiceGroup | mount | 3503 | 3499 | 5000 | |
| ComboBox | mount | 796 | 803 | 1000 | |
| CommandBar | mount | 7645 | 7693 | 1000 | |
| ContextualMenu | mount | 12852 | 13058 | 1000 | |
| DefaultButton | mount | 948 | 926 | 5000 | |
| DetailsRow | mount | 2620 | 2617 | 5000 | |
| DetailsRowFast | mount | 2642 | 2609 | 5000 | |
| DetailsRowNoStyles | mount | 2439 | 2450 | 5000 | |
| Dialog | mount | 3213 | 3232 | 1000 | |
| DocumentCardTitle | mount | 298 | 285 | 1000 | |
| Dropdown | mount | 2451 | 2451 | 5000 | |
| FocusTrapZone | mount | 1431 | 1394 | 5000 | |
| FocusZone | mount | 1413 | 1347 | 5000 | |
| GroupedList | mount | 41293 | 45595 | 2 | |
| GroupedList | virtual-rerender | 22016 | 22104 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 62606 | 62863 | 2 | |
| GroupedListV2 | mount | 284 | 295 | 2 | |
| GroupedListV2 | virtual-rerender | 264 | 272 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 280 | 292 | 2 | |
| IconButton | mount | 1298 | 1299 | 5000 | |
| Label | mount | 446 | 443 | 5000 | |
| Layer | mount | 3359 | 3358 | 5000 | |
| Link | mount | 520 | 530 | 5000 | |
| MenuButton | mount | 1140 | 1148 | 5000 | |
| MessageBar | mount | 25839 | 25980 | 5000 | |
| Nav | mount | 2334 | 2336 | 1000 | |
| OverflowSet | mount | 1022 | 997 | 5000 | |
| Panel | mount | 2167 | 2129 | 1000 | |
| Persona | mount | 921 | 892 | 1000 | |
| Pivot | mount | 1067 | 1095 | 1000 | |
| PrimaryButton | mount | 1044 | 1057 | 5000 | |
| Rating | mount | 5783 | 5797 | 5000 | |
| SearchBox | mount | 1115 | 1110 | 5000 | |
| Shimmer | mount | 2340 | 2306 | 5000 | |
| Slider | mount | 1674 | 1678 | 5000 | |
| SpinButton | mount | 3421 | 3418 | 5000 | |
| Spinner | mount | 519 | 520 | 5000 | |
| SplitButton | mount | 2142 | 2157 | 5000 | |
| Stack | mount | 541 | 540 | 5000 | |
| StackWithIntrinsicChildren | mount | 1084 | 1079 | 5000 | |
| StackWithTextChildren | mount | 3371 | 3391 | 5000 | |
| SwatchColorPicker | mount | 7447 | 7417 | 5000 | |
| TagPicker | mount | 1681 | 1695 | 5000 | |
| Text | mount | 490 | 490 | 5000 | |
| TextField | mount | 1150 | 1142 | 5000 | |
| ThemeProvider | mount | 1016 | 1019 | 5000 | |
| ThemeProvider | virtual-rerender | 796 | 783 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1557 | 1563 | 5000 | |
| Toggle | mount | 782 | 793 | 5000 | |
| buttonNative | mount | 254 | 240 | 5000 |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 24, 2023
* master: (58 commits) fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655) Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577) chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666) applying package updates applying package updates Make line chart screen reader accessible (microsoft#27632) fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172) docs(react-textarea): Update examples to use Field (microsoft#27644) bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555) applying package updates chore: restructure stories, add separate category for flat tree (microsoft#27586) fix document link (microsoft#27499) fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467) chore(react-tabs): adopts custom JSX pragma (microsoft#27640) fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650) feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378) bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642) applying package updates feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637) feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557) ...
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
…ve it undefined) when it is checkable (microsoft#27650) * fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable. * Adding change file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Checkable split buttons inside of contextual menus are not setting
aria-checkedwhen neitherisCheckednorcheckedare passed in.aria-checkedshould be set tofalseif neitherisCheckednorcheckedare passed in.New Behavior
Checkable split buttons inside of contextual menus now set
aria-checkedtofalsewhen neitherisCheckednorcheckedare passed in. We're also now using thegetIsCheckedfunction to determine that since that is what is used at the end to determine if the split button is checkable or not.Related Issue(s)