Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(react-tree): fix parent navigation after independency from id #27642

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Apr 19, 2023

New Behavior

  1. Fix bugs introduced by feat(react-tree): value property over id #27532
  2. Updates test to work properly without id

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f31209:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 19, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4dde6727c7e7fe7fbf6fedb4e1619deddbd3e16a (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.986 kB
18.429 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.27 kB
57.634 kB
react-components
react-components: FluentProvider & webLightTheme
38.773 kB
12.375 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 92f70e62b4c8256f81aae5d521477af851656f5d

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 939 928 5000
Button mount 479 479 5000
Field mount 1700 1717 5000
FluentProvider mount 1134 1113 5000
FluentProviderWithTheme mount 145 153 10
FluentProviderWithTheme virtual-rerender 115 110 10
FluentProviderWithTheme virtual-rerender-with-unmount 122 142 10
InfoButton mount 30 29 5000
MakeStyles mount 1270 1338 50000
Persona mount 2678 2717 5000
SpinButton mount 2034 2073 5000

@bsunderhus bsunderhus marked this pull request as ready for review April 20, 2023 07:24
@bsunderhus bsunderhus requested a review from a team as a code owner April 20, 2023 07:24
@bsunderhus bsunderhus merged commit acbc5fc into microsoft:master Apr 20, 2023
@bsunderhus bsunderhus deleted the react-tree/bugfix--fix-parent-navigation-after-value-pr branch April 20, 2023 08:02
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 24, 2023
* master: (58 commits)
  fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655)
  Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577)
  chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666)
  applying package updates
  applying package updates
  Make line chart screen reader accessible (microsoft#27632)
  fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172)
  docs(react-textarea): Update examples to use Field (microsoft#27644)
  bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555)
  applying package updates
  chore: restructure stories, add separate category for flat tree (microsoft#27586)
  fix document link (microsoft#27499)
  fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467)
  chore(react-tabs): adopts custom JSX pragma (microsoft#27640)
  fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650)
  feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378)
  bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642)
  applying package updates
  feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637)
  feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants