[Nav][Accessibility] Selected items are not announced by narrator #14982
Conversation
Merge changes from fluentui branch into Forked repo
Merge fluentui into fork
This reverts commit 4f2d905.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bcae018:
|
Perf Analysis
All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: f199d137f3aa5cb03989937e6db547463c009d71 (build) |
cimoli-dev
changed the title
There was a problem hiding this comment.
I don't think tab is the right role here. aria-selected is also supported on several other roles including treeitem, which I think would be more appropriate here. In that case the role of the <ul> would need to be changed to tree.
|
@ecraig12345 I'm using tree and treeitem now. However, narrator and JAWS are not announcing the selected property. It appears to be an open issue for both ATs. Because of that i've added a comment about it near the change. |
Thanks for the update! If I remember right from when I started to look into this issue several months ago, the problem may be that |
|
Checking this PR once per day as it would fix one of the bugs currently experienced by one of the projects I work on. |
There was a problem hiding this comment.
Thanks for submitting this fix, but due to work we're currently doing to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit fixes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details.
|
This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI! |
|
This is still an issue and should get fixed because as the user traverses to the "selected" nav item, then the AT doesn't announce it. |
Pull request checklist
$ yarn changeDescription of changes
To get narrator to announced the selected nav item, aria-selected attributed must be added to the list item. However, that attribute is only supported on the following roles: gridcell, option, row, tab.
Because of that, change the role of the items from 'listitem' to 'treeitem' and set the value to true/false depending on if the link is selected.
However, there is a known issue in both narrator and JAWS where the selected state is not being announced. I've added a comment in the code about this.
Aria-selected and aria-checked are not output correctly for trees #432