This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
perf(render): use single Fela renderer #1459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
+ Coverage 73.23% 73.27% +0.04%
==========================================
Files 822 822
Lines 6198 6182 -16
Branches 1802 1775 -27
==========================================
- Hits 4539 4530 -9
+ Misses 1654 1647 -7
Partials 5 5
Continue to review full report at Codecov.
|
Changed dependencies in
Generated by 🚫 dangerJS |
mnajdova
reviewed
Jun 7, 2019
mnajdova
reviewed
Jun 7, 2019
mnajdova
reviewed
Jun 7, 2019
mnajdova
reviewed
Jun 7, 2019
mnajdova
reviewed
Jun 7, 2019
mnajdova
reviewed
Jun 7, 2019
mnajdova
reviewed
Jun 7, 2019
layershifter
force-pushed
the
chore/fela-single-renderer
branch
from
June 7, 2019 11:15
3c2cfc8
to
92b73e1
Compare
…ithub.com/stardust-ui/react into chore/fela-single-renderer # Conflicts: # packages/react/test/specs/commonTests/htmlIsAccessibilityCompliant.ts # packages/react/test/specs/commonTests/isConformant.tsx # packages/react/test/utils/index.ts # packages/react/test/utils/withProvider.tsx
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
miroslavstastny
as code owners
June 10, 2019 15:21
…ore/fela-single-renderer # Conflicts: # packages/react/package.json
miroslavstastny
approved these changes
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1311.
Problem
Previously we had multiple Fela renderers for LTR and RTL.
Why it is a problem?
Why we need this previously?
fela-plugin-rtl
, were added in10.2.1
fela-plugin-embedded
, required fix for its usage was release in10.4.1
With latest changes in Fela we can remove this tricks 🚀