Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

perf(render): use single Fela renderer #1459

Merged
merged 12 commits into from
Jun 18, 2019
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jun 6, 2019

Fixes #1311.

Problem

Previously we had multiple Fela renderers for LTR and RTL.

Why it is a problem?

Why we need this previously?

  • conditional style transforms with fela-plugin-rtl, were added in 10.2.1
  • proper support for RTL in animations - fixed with usage fela-plugin-embedded, required fix for its usage was release in 10.4.1

With latest changes in Fela we can remove this tricks 🚀

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1459 into master will increase coverage by 0.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   73.23%   73.27%   +0.04%     
==========================================
  Files         822      822              
  Lines        6198     6182      -16     
  Branches     1802     1775      -27     
==========================================
- Hits         4539     4530       -9     
+ Misses       1654     1647       -7     
  Partials        5        5
Impacted Files Coverage Δ
...src/themes/teams/components/Loader/loaderStyles.ts 0% <ø> (ø) ⬆️
.../src/themes/base/components/Loader/loaderStyles.ts 12.5% <0%> (ø) ⬆️
packages/react/src/lib/mergeProviderContexts.ts 100% <100%> (ø) ⬆️
packages/react/src/lib/felaRenderer.tsx 66.66% <100%> (-8.34%) ⬇️
packages/react/src/lib/getClasses.ts 100% <100%> (ø) ⬆️
...ackages/react/src/components/Provider/Provider.tsx 95.34% <100%> (-0.49%) ⬇️
...ackages/react/src/lib/felaInvokeKeyframesPlugin.ts 92.3% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bd725...87c251c. Read the comment docs.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jun 6, 2019

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!
Warnings
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies in packages/react/package.json

package before after
fela ^10.2.0 ^10.5.0
fela-plugin-fallback-value ^10.2.0 ^10.5.0
fela-plugin-placeholder-prefixer ^10.2.0 ^10.5.0
fela-plugin-prefixer ^10.2.0 ^10.5.0
fela-plugin-rtl ^10.2.0 ^10.5.0
react-fela ^10.2.0 ^10.5.0
fela-plugin-embedded - ^10.5.0

Generated by 🚫 dangerJS

…ithub.com/stardust-ui/react into chore/fela-single-renderer

# Conflicts:
#	packages/react/test/specs/commonTests/htmlIsAccessibilityCompliant.ts
#	packages/react/test/specs/commonTests/isConformant.tsx
#	packages/react/test/utils/index.ts
#	packages/react/test/utils/withProvider.tsx
…ore/fela-single-renderer

# Conflicts:
#	packages/react/package.json
@layershifter layershifter merged commit 0e69305 into master Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/fela-single-renderer branch June 18, 2019 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fela memory improvements
4 participants