Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

CSS in JS issues #66

Closed
levithomason opened this issue Aug 8, 2018 · 6 comments
Closed

CSS in JS issues #66

levithomason opened this issue Aug 8, 2018 · 6 comments
Labels
vsts Paired with ticket in vsts

Comments

@levithomason
Copy link
Member

We'll track CSS in JS issues we're having here and propose solutions later.

  1. Cannot switch to a different renderer (normal, rtl) during the life of the app [IMPORTANT] fix(rtl): disable RendererProvider rehydration #58
  2. We'll need to support multiple React roots on a single page.
@robinweser
Copy link

robinweser commented Aug 16, 2018

@levithomason FWIW, we're thinking about introducing dynamic direction support, adding the ability to switch rtl => ltr dynamically as well as having different modes for different sub trees :)

PS: I was thrilled to see Fela in the code here. Looks like a very promising UI library. If there's anything I can help with, feel free to hit me up =)

@levithomason
Copy link
Member Author

we're thinking about introducing dynamic direction support

That would be awesome. This is one of the big hurdles for us now.

The other goal we have is to reduce the number of wrapping components around every UI component. This is the reason we are using the renderer directly opposed to an HOC.

@miroslavstastny
Copy link
Member

  1. Fela does not prefix keyframe class names - RTL keyframes rewrite LTR ones Keyframes are not behaving as expect when RTL is switched #516

@miroslavstastny
Copy link
Member

  1. Fela incompatible with --isolatedModules Unable to use Stardust in TS project with --isolatedModules #613

@layershifter
Copy link
Member

After #1459 we will not need to switch renderers.
Fela is also compatible with TS --isolatedModules now 🚀

@levithomason
Copy link
Member Author

Both the original issues are now solved 💪

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

5 participants