Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark github actions workflow, run and report tachometer results #5991

Merged

Conversation

prudepixie
Copy link
Contributor

Add benchmark github actions workflow, run and report tachometer results in a automated message

Pull Request

πŸ“– Description

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@github-actions
Copy link

github-actions bot commented May 17, 2022

πŸ“Š Tachometer Benchmark Results

Summary

create10k

  • render-create10k: slower ❌ 1% - 4% (15.73ms - 41.34ms)
    local vs latest Customize summary
  • test-create10k: unsure πŸ” -4% - +7% (-26.08ms - +50.73ms)
    1.10.1 vs 1.6.0 Customize summary

createDelete5x

  • render-createDelete5x: slower ❌ 4% - 7% (85.94ms - 133.60ms)
    local vs latest Customize summary

update10th

  • render-update10th: slower ❌ 0% - 3% (1.23ms - 12.92ms)
    local vs latest Customize summary
  • test-update10th: unsure πŸ” -1% - +1% (-6.33ms - +7.34ms)
    1.10.1 vs 1.6.0 Customize summary

usedJSHeapSize

  • render-create10k: faster βœ” 3% - 3% (0.37ms - 0.44ms)
    local vs latest Customize summary
  • render-createDelete5x: faster βœ” 7% - 8% (4.65ms - 5.20ms)
    local vs latest Customize summary
  • render-update10th: faster βœ” 3% - 4% (0.42ms - 0.57ms)
    local vs latest Customize summary
  • test-create10k: unsure πŸ” -0% - +0% (-0.00ms - +0.01ms)
    1.10.1 vs 1.6.0 Customize summary
  • test-update10th: unsure πŸ” -0% - +0% (-0.00ms - +0.01ms)
    1.10.1 vs 1.6.0 Customize summary

Results

render-create10k

create10k

VersionAvg timevs latestvs local
latest1104.52ms - 1123.96ms-faster βœ”
1% - 4%
15.73ms - 41.34ms
local1134.44ms - 1151.11msslower ❌
1% - 4%
15.73ms - 41.34ms
-

usedJSHeapSize

VersionAvg timevs latestvs local
latest14.03ms - 14.04ms-slower ❌
3% - 3%
0.37ms - 0.44ms
local13.59ms - 13.67msfaster βœ”
3% - 3%
0.37ms - 0.44ms
-
render-createDelete5x

createDelete5x

VersionAvg timevs latestvs local
latest2040.41ms - 2070.76ms-faster βœ”
4% - 6%
85.94ms - 133.60ms
local2146.98ms - 2183.73msslower ❌
4% - 7%
85.94ms - 133.60ms
-

usedJSHeapSize

VersionAvg timevs latestvs local
latest65.91ms - 66.09ms-slower ❌
8% - 9%
4.65ms - 5.20ms
local60.82ms - 61.33msfaster βœ”
7% - 8%
4.65ms - 5.20ms
-
render-update10th

update10th

VersionAvg timevs latestvs local
latest514.33ms - 521.06ms-faster βœ”
0% - 2%
1.23ms - 12.92ms
local519.99ms - 529.56msslower ❌
0% - 3%
1.23ms - 12.92ms
-

usedJSHeapSize

VersionAvg timevs latestvs local
latest14.05ms - 14.06ms-slower ❌
3% - 4%
0.42ms - 0.57ms
local13.48ms - 13.63msfaster βœ”
3% - 4%
0.42ms - 0.57ms
-
test-create10k

create10k

VersionAvg timevs 1.6.0vs 1.10.1
1.6.0667.12ms - 714.56ms-unsure πŸ”
-7% - +4%
-50.73ms - +26.08ms
1.10.1672.96ms - 733.36msunsure πŸ”
-4% - +7%
-26.08ms - +50.73ms
-

usedJSHeapSize

VersionAvg timevs 1.6.0vs 1.10.1
1.6.014.04ms - 14.04ms-unsure πŸ”
-0% - +0%
-0.01ms - +0.00ms
1.10.114.04ms - 14.05msunsure πŸ”
-0% - +0%
-0.00ms - +0.01ms
-
test-update10th

update10th

VersionAvg timevs 1.6.0vs 1.10.1
1.6.0507.20ms - 520.19ms-unsure πŸ”
-1% - +1%
-7.34ms - +6.33ms
1.10.1512.07ms - 516.33msunsure πŸ”
-1% - +1%
-6.33ms - +7.34ms
-

usedJSHeapSize

VersionAvg timevs 1.6.0vs 1.10.1
1.6.014.05ms - 14.05ms-unsure πŸ”
-0% - +0%
-0.01ms - +0.00ms
1.10.114.05ms - 14.06msunsure πŸ”
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for Fast Element benchmark jobs

@prudepixie prudepixie linked an issue May 20, 2022 that may be closed by this pull request
@prudepixie prudepixie marked this pull request as ready for review May 24, 2022 21:41
@prudepixie prudepixie merged commit 67afcd4 into users/wendy/fast-benchmarks-5845 May 24, 2022
@prudepixie prudepixie deleted the users/wendy/bench-actions branch May 24, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: first iteration of adding benchmarks to Github Actions
1 participant