Update workflow to test local fast-element build #5994

prudepixie · 2022-05-17T17:09:07Z

Pull Request

📖 Description

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

I have included a change request file using $ yarn change
I have added tests for my changes.
I have tested my changes.
I have updated the project documentation to reflect my changes.
I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

I have added a new component
I have modified an existing component
I have updated the definition file
I have updated the configuration file

⏭ Next Steps

github-actions · 2022-05-17T17:10:10Z

📊 Tachometer Benchmark Results

Summary

⏱ fast-element-test
⏱ results-create10k

create10k

localTest-create10k: faster ✔ 0% - 7% (1.20ms - 51.10ms)
^{1.10.1 vs local Customize summary}
localTest-create10k: faster ✔ 2% - 3% (17.00ms - 27.48ms)
^{1.10.1 vs local Customize summary}
localTest-create10k: unsure 🔍 -6% - +1% (-36.48ms - +5.49ms)
^{1.8.0 vs local Customize summary}
results-create-local: faster ✔ 0% - 7% (1.20ms - 51.10ms)
^{1.10.1 vs local Customize summary}

update10th

results: unsure 🔍 -8% - +9% (-36.39ms - +38.01ms)
^{1.10.1 vs 1.6.0 Customize summary}
test-update10th: unsure 🔍 -2% - +1% (-11.86ms - +5.53ms)
^{1.10.1 vs 1.6.0 Customize summary}
update10th: unsure 🔍 -8% - +9% (-36.39ms - +38.01ms)
^{1.10.1 vs 1.6.0 Customize summary}

usedJSHeapSize

localTest-create10k: slower ❌ 7% - 7% (0.87ms - 0.95ms)
^{1.10.1 vs local Customize summary}
localTest-create10k: slower ❌ 3% - 4% (0.38ms - 0.51ms)
^{1.10.1 vs local Customize summary}
localTest-create10k: unsure 🔍 -0% - -0% (-0.02ms - -0.01ms)
^{1.8.0 vs local Customize summary}
results: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
^{1.10.1 vs 1.6.0 Customize summary}
results-create-local: slower ❌ 7% - 7% (0.87ms - 0.95ms)
^{1.10.1 vs local Customize summary}
test-update10th: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
^{1.10.1 vs 1.6.0 Customize summary}
update10th: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
^{1.10.1 vs 1.6.0 Customize summary}

Results

⏱ fast-element-test

Currently running in Fast Element benchmark jobs #25…

localTest-create10k

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #42
Commit: e899016

create10k

Version	Avg time	vs local	vs 1.10.1
local	686.07ms - 722.91ms	-	slower ❌ 0% - 8% 1.20ms - 51.10ms
1.10.1	661.51ms - 695.17ms	faster ✔ 0% - 7% 1.20ms - 51.10ms	-

usedJSHeapSize

Version	Avg time	vs local	vs 1.10.1
local	13.10ms - 13.17ms	-	faster ✔ 6% - 7% 0.87ms - 0.95ms
1.10.1	14.04ms - 14.05ms	slower ❌ 7% - 7% 0.87ms - 0.95ms	-

localTest-create10k

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #67
Commit: a57e7dc

create10k

Version	Avg time	vs local	vs 1.10.1
local	893.66ms - 901.38ms	-	slower ❌ 2% - 3% 17.00ms - 27.48ms
1.10.1	871.74ms - 878.82ms	faster ✔ 2% - 3% 17.00ms - 27.48ms	-

usedJSHeapSize

Version	Avg time	vs local	vs 1.10.1
local	13.53ms - 13.65ms	-	faster ✔ 3% - 4% 0.38ms - 0.51ms
1.10.1	14.03ms - 14.04ms	slower ❌ 3% - 4% 0.38ms - 0.51ms	-

localTest-create10k

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #66
Commit: 61dd718

create10k

Version	Avg time	vs local	vs 1.8.0
local	656.21ms - 665.93ms	-	unsure 🔍 -1% - +6% -5.49ms - +36.48ms
1.8.0	625.15ms - 665.99ms	unsure 🔍 -6% - +1% -36.48ms - +5.49ms	-

usedJSHeapSize

Version	Avg time	vs local	vs 1.8.0
local	14.05ms - 14.06ms	-	unsure 🔍 +0% - +0% +0.01ms - +0.02ms
1.8.0	14.04ms - 14.05ms	unsure 🔍 -0% - -0% -0.02ms - -0.01ms	-

results

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #35
Commit: 4bfbb74

update10th

Version	Avg time	vs 1.6.0	vs 1.10.1
1.6.0	418.56ms - 467.88ms	-	unsure 🔍 -9% - +8% -38.01ms - +36.39ms
1.10.1	416.17ms - 471.88ms	unsure 🔍 -8% - +9% -36.39ms - +38.01ms	-

usedJSHeapSize

Version	Avg time	vs 1.6.0	vs 1.10.1
1.6.0	14.05ms - 14.05ms	-	unsure 🔍 -0% - -0% -0.01ms - -0.00ms
1.10.1	14.06ms - 14.06ms	unsure 🔍 +0% - +0% +0.00ms - +0.01ms	-

results-create-local

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #35
Commit: 4bfbb74

create10k

Version	Avg time	vs local	vs 1.10.1
local	686.07ms - 722.91ms	-	slower ❌ 0% - 8% 1.20ms - 51.10ms
1.10.1	661.51ms - 695.17ms	faster ✔ 0% - 7% 1.20ms - 51.10ms	-

usedJSHeapSize

Version	Avg time	vs local	vs 1.10.1
local	13.10ms - 13.17ms	-	faster ✔ 6% - 7% 0.87ms - 0.95ms
1.10.1	14.04ms - 14.05ms	slower ❌ 7% - 7% 0.87ms - 0.95ms	-

⏱ results-create10k

Currently running in Fast Element benchmark jobs #50…

test-update10th

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #67
Commit: a57e7dc

update10th

Version	Avg time	vs 1.6.0	vs 1.10.1
1.6.0	637.42ms - 650.18ms	-	unsure 🔍 -1% - +2% -5.53ms - +11.86ms
1.10.1	634.72ms - 646.55ms	unsure 🔍 -2% - +1% -11.86ms - +5.53ms	-

usedJSHeapSize

Version	Avg time	vs 1.6.0	vs 1.10.1
1.6.0	14.05ms - 14.06ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
1.10.1	14.05ms - 14.06ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

update10th

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Fast Element benchmark jobs #42
Commit: e899016

update10th

Version	Avg time	vs 1.6.0	vs 1.10.1
1.6.0	418.56ms - 467.88ms	-	unsure 🔍 -9% - +8% -38.01ms - +36.39ms
1.10.1	416.17ms - 471.88ms	unsure 🔍 -8% - +9% -36.39ms - +38.01ms	-

usedJSHeapSize

Version	Avg time	vs 1.6.0	vs 1.10.1
1.6.0	14.05ms - 14.05ms	-	unsure 🔍 -0% - -0% -0.01ms - -0.00ms
1.10.1	14.06ms - 14.06ms	unsure 🔍 +0% - +0% +0.00ms - +0.01ms	-

_{tachometer-reporter-action v2 for Fast Element benchmark jobs}

prudepixie · 2022-05-17T23:50:55Z

Up to here, seems to work if feeding the results json file with the commit and uploading artifact for github actions to read

update back to pr

2325860

prudepixie requested review from awentzel, janechu, nicholasrice, chrisdholt and EisenbergEffect as code owners May 17, 2022 17:09

add specific operation

cb7ecf5

prudepixie force-pushed the users/wendy/local-build-actions branch from a129e9b to cb7ecf5 Compare May 17, 2022 17:35

Wendy and others added 12 commits May 17, 2022 10:36

fix workflow syntax

23f2395

add version test

b50d6fb

add fast-element version

482226a

move local implementation to separate test

46e4fef

fix scripts, res dist

f9c0f2a

test git hook

4d57b86

revert

c1a40c8

Update ci-benchmarks.yml

8c15a0a

Update ci-benchmarks.yml

9ab1a7c

upload artifact instead of download

112ac07

Update ci-benchmarks.yml

48117aa

add local results

fad4a7d

Wendy added 8 commits May 18, 2022 10:54

report local build res

d66b394

use benchmark script

d2cf729

git res path

8c4a3f0

get rid of pr-bench-name

ea6867e

add fozen lockfile to setupCommand

bee4daa

add some logs

ec0beb3

remove cache steps

4db6779

redo

be0f927

Wendy Hsu and others added 7 commits May 18, 2022 15:39

test hook

0e7b605

test with versioned workspace

02083ad

Update ci-benchmarks.yml

ac16a4a

delete steps from jobs

82a26cc

hard code branch name

4be2d0e

Update ci-benchmarks.yml

5f89d02

hardcode local fast-element version

f8e7a0b

prudepixie linked an issue May 20, 2022 that may be closed by this pull request

perf: first iteration of adding benchmarks to Github Actions #5844

Closed

prudepixie marked this pull request as draft May 20, 2022 17:27

take out swapping package version prop from config

1bd7f26

prudepixie force-pushed the users/wendy/local-build-actions branch from 6f423e9 to 1bd7f26 Compare May 23, 2022 17:19

Wendy Hsu added 4 commits May 23, 2022 11:00

change to local build

4e63c61

install before building benchmark

c380bca

fix build

9e103c9

update local path to file

d5a908e

prudepixie force-pushed the users/wendy/local-build-actions branch from 6d2824f to d5a908e Compare May 23, 2022 19:56

Wendy Hsu and others added 11 commits May 23, 2022 14:06

add to nohoist

cfc4c1f

install

e24be32

Update ci-benchmarks.yml

027656f

depe

4e250e7

add working workflow

452b36a

delete some scripts

3a829cf

add packageVersion

2bb249c

turn off no hoist for packages

7ccc77a

add local test

24cf18d

clean up

935e831

getting branchname spawn seems to time out

b1f8e4d

prudepixie marked this pull request as ready for review May 24, 2022 16:27

prudepixie merged commit 6f0eeec into users/wendy/bench-actions May 24, 2022

prudepixie deleted the users/wendy/local-build-actions branch May 24, 2022 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update workflow to test local fast-element build #5994

Update workflow to test local fast-element build #5994

prudepixie commented May 17, 2022

github-actions bot commented May 17, 2022 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

create10k

update10th

usedJSHeapSize

Results

create10k

usedJSHeapSize

create10k

usedJSHeapSize

create10k

usedJSHeapSize

update10th

usedJSHeapSize

create10k

usedJSHeapSize

update10th

usedJSHeapSize

update10th

usedJSHeapSize

prudepixie commented May 17, 2022

Update workflow to test local fast-element build #5994

Update workflow to test local fast-element build #5994

Conversation

prudepixie commented May 17, 2022

Pull Request

📖 Description

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

Component-specific

⏭ Next Steps

github-actions bot commented May 17, 2022 • edited Loading

📊 Tachometer Benchmark Results

Summary

create10k

update10th

usedJSHeapSize

Results

create10k

usedJSHeapSize

create10k

usedJSHeapSize

create10k

usedJSHeapSize

update10th

usedJSHeapSize

create10k

usedJSHeapSize

update10th

usedJSHeapSize

update10th

usedJSHeapSize

prudepixie commented May 17, 2022

github-actions bot commented May 17, 2022 •

edited

Loading