Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init fast-benchmarks directory, includes #5792, #5842 #5888

Closed
wants to merge 106 commits into from
Closed

init fast-benchmarks directory, includes #5792, #5842 #5888

wants to merge 106 commits into from

Conversation

prudepixie
Copy link
Contributor

Pull Request

📖 Description

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@EisenbergEffect @nicholasrice
feat(compiler): remove tree walker & switch to structural target lookup
7c4253d
@EisenbergEffect @nicholasrice
fix(compiler): don't add unnecessary descriptors to compile result
2d0dafc
@EisenbergEffect @nicholasrice
fix(compiler): correct extraction of child index from parent id
30433f5
@EisenbergEffect @nicholasrice
feat(compiler): unify host and view factories
a1666e5
@EisenbergEffect @nicholasrice
feat(view): unify behavior creation with first bind; clean up compiler
5f8874c
@EisenbergEffect @nicholasrice
chore(template): clean up imports
44230ef
@EisenbergEffect @nicholasrice
chore(templating): clean up imports
52ba635
@EisenbergEffect @nicholasrice
refactor(view): cleanup view internals and remove range
bbbbfcb
@EisenbergEffect @nicholasrice
feat(binding): enable control over className vs. classList behavior
56580a1
@EisenbergEffect @nicholasrice
docs: add notes on changes in FAST Element 2
a01da9f
@EisenbergEffect @nicholasrice
feat: add generic types to views and templates
5a5203a
@EisenbergEffect @nicholasrice
refactor: internal cleanup and fixing router to match new APIs.
59d5f26
@EisenbergEffect @nicholasrice
feat: improve types related to behaviors
30cc268
@EisenbergEffect @nicholasrice
refactor: clean up styles code a bit
73a5b0c
@EisenbergEffect @nicholasrice
feat: introduce ViewBehavior to enable stateless behaviors
e2edcc6
@EisenbergEffect @nicholasrice
fix: remove unnecessary render based on element id
1c4b36e
@EisenbergEffect @nicholasrice
perf: switch targetId to set and use normal props for r/h lookups
30b0cec
@EisenbergEffect @nicholasrice
refactor(observable): tighten up some code
160e975
@EisenbergEffect @nicholasrice
refactor: tighten up notifier
3ee45d7
@EisenbergEffect @nicholasrice
refactor: clean up array observer
3addc2b
@EisenbergEffect @nicholasrice
refactor: clean up class binding scenarios
4593fdc
@EisenbergEffect @nicholasrice
refactor: clean up more internal of css and observable
b50f082
@EisenbergEffect @nicholasrice
feat: switch ref over to the new stateless model for view behaviors
8b40abf
@EisenbergEffect @nicholasrice
refactor: cleanup in node observation
cddc252
@EisenbergEffect @nicholasrice
feat: createCustomAttributePlaceholder no longer requires an attr name
808ec14
@EisenbergEffect @nicholasrice
feat: update children and slotted to share instances
e090e17
@EisenbergEffect @nicholasrice
refactor: dry up ref and node observation directives
20f6244
@EisenbergEffect @nicholasrice
refactor: improve compiler internals by combining context and result
ce086b8
@EisenbergEffect @nicholasrice
feat: wip updating binding system to support modes and configs
1aeeaa7
@EisenbergEffect @nicholasrice
fix: correct handle change signature for content binding
6f5dbdf
@prudepixie prudepixie linked an issue Apr 25, 2022 that may be closed by this pull request
perf: add scripts to generate dynamic tachometer config file #5842
Closed
@prudepixie prudepixie added the feature A new feature label Apr 25, 2022
@prudepixie prudepixie self-assigned this Apr 25, 2022
@prudepixie prudepixie mentioned this pull request Apr 25, 2022
Closed
9 tasks
prudepixie and others added 5 commits April 29, 2022 14:41
@prudepixie
add default operations, enable user to add and run custom operations …
0e9f246 
…5841 (#5921)

* added update 10th test, moved all template generate logic to template.js, now  just need to add one .ts file to run benchmark

* add default tests

* enable operations argument to run specified operations

Co-authored-by: Wendy <[email protected]>
delete console.log
ffad92b
error handle if operations length is 0
57722d0
@prudepixie
Update README.md (#5934)
5a8131c
@prudepixie
manually add fast-foundation dep (#5935)
3c10f95 
* adding chalk for logging, separate memory benchmarks result

* manually add fast-foundation dependencies

* made adjustments to run fast-foundation test

Co-authored-by: Wendy <[email protected]>
@nicholasrice nicholasrice force-pushed the features/fast-element-2 branch from 9739096 to 74c0c9b Compare May 4, 2022 17:48
@nicholasrice nicholasrice force-pushed the features/fast-element-2 branch from 613715e to 8d37630 Compare May 5, 2022 17:25
@nicholasrice nicholasrice force-pushed the features/fast-element-2 branch from 8d37630 to caaa685 Compare May 9, 2022 19:19
prudepixie added 2 commits May 19, 2022 10:03
@prudepixie
add append related benchmarks (#6002)
d57f97b 
* adding append method benchmarks and operation
* yarn.lock updates
@prudepixie
feat: add arguments in cli to support methods queryparam, repeat exam…
7062900 
…ple (#6022)
This was linked to issues May 24, 2022
perf: add query params to run benchmarks for repeat #6001
Closed
perf: first iteration of adding benchmarks to Github Actions #5844
Closed
perf: add Krausest inspired tests as default test suite #5841
Closed
@prudepixie
Add benchmark github actions workflow, run and report tachometer resu…
67afcd4 
…lts (#5991)

* pass local branch name from github actions  (#6019)

* better null check

Co-authored-by: Wendy <[email protected]>
@prudepixie prudepixie removed a link to an issue May 24, 2022
perf: first iteration of adding benchmarks to Github Actions #5844
Closed
@prudepixie prudepixie closed this May 25, 2022
@prudepixie prudepixie mentioned this pull request May 25, 2022
Closed
9 tasks
@prudepixie
Copy link
Contributor Author

moved all relevant changes to new PR: #6026

@prudepixie prudepixie deleted the users/wendy/fast-benchmarks-5845 branch May 25, 2022 18:04
@prudepixie prudepixie mentioned this pull request Jun 14, 2022
Merged
9 tasks
@EisenbergEffect EisenbergEffect removed this from the FAST Element 2.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prudepixie prudepixie

Labels
feature A new feature
Projects
None yet
Milestone
No milestone
6 participants
@prudepixie @EisenbergEffect @nicholasrice @janechu @williamw2 @chrisdholt