Accordion default slot #5514
Merged
Accordion default slot #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4thieulavoie
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
m4thieulavoie
commented
Jan 12, 2022
| @@ -15,10 +15,7 @@ export const accordionItemTemplate: ( | |||
| context: ElementDefinitionContext, | |||
| definition: AccordionItemOptions | |||
| ) => html` | |||
| <template | |||
| class="${x => (x.expanded ? "expanded" : "")}" | |||
| slot="item" | |||
There was a problem hiding this comment.
Turns out FAST was automatically adding the slot under the hood. I assume only a tiny portion of the consumers will have to keep their eyes open for a breaking change, as long as they use a component extending AccordionItem
m4thieulavoie
commented
Jan 12, 2022
| @@ -14,8 +14,9 @@ export const accordionTemplate: ( | |||
| ) => ViewTemplate<Accordion> = ( | |||
| context: ElementDefinitionContext, | |||
| definition: FoundationElementDefinition | |||
| ) => html` | |||
| ) => /* TODO: deprecate slot name `item` to only support default slot https://github.com/microsoft/fast/issues/XXXX */ html` | |||
There was a problem hiding this comment.
@chrisdholt did you want to create the issue, or do you want me to, and you would add any additional details afterwards?
There was a problem hiding this comment.
Would you mind taking care of this? Thank you!
chrisdholt
approved these changes
Jan 12, 2022
EisenbergEffect
approved these changes
Jan 12, 2022
eljefe223
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR addresses the issue in accordion where it's unclear whether the slot name is
"item"or"". We now default to a default slot, while maintaining backward compatibility.Fixes #5437
🎫 Issues
#5437
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps