Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate item slot in accordion #5515

Closed
m4thieulavoie opened this issue Jan 12, 2022 · 3 comments
Closed

feat: deprecate item slot in accordion #5515

m4thieulavoie opened this issue Jan 12, 2022 · 3 comments
Labels
area:fast-foundation Pertains to fast-foundation breaking-change A breaking change to a shipping package community:request Issues specifically reported by a member of the community. status:planned Work is planned warning:stale No recent activity within a reasonable amount of time

Comments

@m4thieulavoie
Copy link
Collaborator

🙋 Feature Request

Follow-up of #5437 . This issue is for tracking the deprecation of the item slot name in the Accordion component. Once #5514 merges in, Accordion should support both a default slot and the item one, but in the next major version, we'll want to get rid of the latter to keep a lean API. Note that as soon as the above PR merges in, no mention of item will be present in the docs

🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

🔦 Context

💻 Examples
@m4thieulavoie m4thieulavoie added the status:triage New Issue - needs triage label Jan 12, 2022
@m4thieulavoie
Copy link
Collaborator Author

@chrisdholt feel free to fill in any missing piece of information!

@EisenbergEffect EisenbergEffect added area:fast-components area:fast-foundation Pertains to fast-foundation breaking-change A breaking change to a shipping package community:request Issues specifically reported by a member of the community. status:planned Work is planned and removed status:triage New Issue - needs triage labels Jan 18, 2022
@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 18, 2022
@chrisdholt chrisdholt mentioned this issue May 5, 2022
Merged
9 tasks
@chrisdholt
Copy link
Member

Closed w/ #5945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:fast-foundation Pertains to fast-foundation breaking-change A breaking change to a shipping package community:request Issues specifically reported by a member of the community. status:planned Work is planned warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EisenbergEffect @chrisdholt @m4thieulavoie