chore: reverting to use of xmlns https back to http #3699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
xmlns="https:
is invalid for files on CDN or that are referenced as a link. If they are embedded in HTML as text it's fine, which is what I think webpack does for most of our images.Reference: https://stackoverflow.com/questions/18467982/are-svg-parameters-such-as-xmlns-and-version-needed
Motivation & context
favicons are broken after recent updates. This will revert those changes and set back to correct.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist