Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reverting to use of xmlns https back to http #3699

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

awentzel
Copy link
Collaborator

Description

Using xmlns="https: is invalid for files on CDN or that are referenced as a link. If they are embedded in HTML as text it's fine, which is what I think webpack does for most of our images.

Reference: https://stackoverflow.com/questions/18467982/are-svg-parameters-such-as-xmlns-and-version-needed

Motivation & context

favicons are broken after recent updates. This will revert those changes and set back to correct.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@awentzel awentzel self-assigned this Aug 12, 2020
@awentzel awentzel added the area:dev-ops Pertains to build, CI, and other dev-ops work label Aug 12, 2020
@awentzel awentzel added this to the Release 06 milestone Aug 12, 2020
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should matter really as the xmlns isn't typically looked up. I think it can technically even be a custom scheme.

@awentzel awentzel merged commit 0cac64a into master Aug 12, 2020
@awentzel awentzel deleted the revert-3658-users/awentzel/ws1262 branch August 12, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-ops Pertains to build, CI, and other dev-ops work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants