feat: add side navigation for social links and scroll #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamanthaAO
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
awentzel
changed the title
janechu
reviewed
May 29, 2020
sites/fast-website/src/app/components/side-navigation/side-navigation.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/side-navigation/side-navigation.ts
Outdated
Show resolved
Hide resolved
radium-v
requested changes
May 29, 2020
sites/fast-website/src/app/components/side-navigation/side-navigation.styles.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/side-navigation/side-navigation.styles.ts
Show resolved
Hide resolved
sites/fast-website/src/app/components/side-navigation/side-navigation.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/side-navigation/side-navigation.ts
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Jun 1, 2020
janechu
approved these changes
Jun 1, 2020
SamanthaAO
force-pushed
the
users/v-sorcut/hero-links
branch
from
6264b61 to
8c8cf81
Compare
freefaller69
approved these changes
Jun 1, 2020
radium-v
requested changes
Jun 2, 2020
sites/fast-website/src/app/components/side-navigation/side-navigation.ts
Outdated
Show resolved
Hide resolved
…g for medium, update community data and content-placement-container community data
…nctions accordingly
…event default removes hash from url, update display to flex
…tter on scroll when scrolling from the bottom to the top of the page
…ers. Made style changes to scroll indicators so they change size less
SamanthaAO
force-pushed
the
users/v-sorcut/hero-links
branch
from
c4e8b4a to
04ca1be
Compare
radium-v
approved these changes
Jun 2, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* create side-navigation component, update main index and style, add svg for medium, update community data and content-placement-container community data * have section array pull from document to increate reuse * add parent attributes to repeat in template to reduce styles * update naming for greater reusability * update section id's in index to be the names of section and update functions accordingly * add intersection observer, add click events fro link so that event.prevent default removes hash from url, update display to flex * add id's after rebase and add updateScrollIncreasing function for stutter on scroll when scrolling from the bottom to the top of the page * moved intersection observer into constructor and removed eventListerners. Made style changes to scroll indicators so they change size less * make styling changes recomended in comments Co-authored-by: Sam Orcutt <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* create side-navigation component, update main index and style, add svg for medium, update community data and content-placement-container community data * have section array pull from document to increate reuse * add parent attributes to repeat in template to reduce styles * update naming for greater reusability * update section id's in index to be the names of section and update functions accordingly * add intersection observer, add click events fro link so that event.prevent default removes hash from url, update display to flex * add id's after rebase and add updateScrollIncreasing function for stutter on scroll when scrolling from the bottom to the top of the page * moved intersection observer into constructor and removed eventListerners. Made style changes to scroll indicators so they change size less * make styling changes recomended in comments Co-authored-by: Sam Orcutt <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* create side-navigation component, update main index and style, add svg for medium, update community data and content-placement-container community data * have section array pull from document to increate reuse * add parent attributes to repeat in template to reduce styles * update naming for greater reusability * update section id's in index to be the names of section and update functions accordingly * add intersection observer, add click events fro link so that event.prevent default removes hash from url, update display to flex * add id's after rebase and add updateScrollIncreasing function for stutter on scroll when scrolling from the bottom to the top of the page * moved intersection observer into constructor and removed eventListerners. Made style changes to scroll indicators so they change size less * make styling changes recomended in comments Co-authored-by: Sam Orcutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**Note currently there are 9 links in the scroll in the right. This is because the links are created from how many sections there are in the index. In PR #3185 the index is restructured to have 5 sections as there should be and that will fix this problem. I have also commented where else can be changed once that PR goes through.
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist