feat: add background image and preliminary effects #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
sites/fast-website/src/app/components/background-design/background-design.ts
Outdated
Show resolved
Hide resolved
SamanthaAO
reviewed
May 26, 2020
|
|
eljefe223
reviewed
May 26, 2020
|
@SamanthaAO the wide section may be addressed by an upcoming improvement from @eljefe223 |
radium-v
force-pushed
the
users/jokreitl/site-bg-animations
branch
3 times, most recently
from
908e60c to
f6d4b7d
Compare
eljefe223
approved these changes
May 27, 2020
khamudom
approved these changes
May 27, 2020
8 tasks
radium-v
force-pushed
the
users/jokreitl/site-bg-animations
branch
from
88b9f52 to
23e4558
Compare
nicholasrice
approved these changes
May 29, 2020
radium-v
force-pushed
the
users/jokreitl/site-bg-animations
branch
from
23e4558 to
e9abc11
Compare
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* Update eslintrc rule * Add background-design component * Revert webpack dev settings * Compress background svg * Fix background container structure * Remove scrolling filter effect
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Update eslintrc rule * Add background-design component * Revert webpack dev settings * Compress background svg * Fix background container structure * Remove scrolling filter effect
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* Update eslintrc rule * Add background-design component * Revert webpack dev settings * Compress background svg * Fix background container structure * Remove scrolling filter effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the background image as a new component
that reacts when the page is scrolled. I did my best to use cached values where possible. Mobile performance will need to be addressed as my current setup doesn't allow me to test directly on my mobile devices.This PR also includes structural changes for sections and adds in some typography variable fixes.
Motivation & context
While we don't have a fully-animated design, this component allows for us to drop in an isolated solution in the future.
Issue type checklist
Is this a breaking change?
Process & policy checklist