Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add section layout to the website #3068

Merged
merged 2 commits into from
May 7, 2020
Merged

chore: add section layout to the website #3068

merged 2 commits into from
May 7, 2020

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented May 6, 2020

Description

Currently, we just have a blank page, so I created some placeholder sections for the components, by adding, header, section, and footer.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom requested review from radium-v and eljefe223 May 6, 2020 19:09
@khamudom khamudom self-assigned this May 6, 2020
janechu
janechu reviewed May 6, 2020
View reviewed changes
sites/fast-website/src/public/index.html Outdated Show resolved Hide resolved
sites/fast-website/src/public/style.css Outdated Show resolved Hide resolved
sites/fast-website/src/public/index.html Outdated Show resolved Hide resolved
sites/fast-website/src/public/index.html Outdated Show resolved Hide resolved
@radium-v radium-v mentioned this pull request May 6, 2020
Merged
8 tasks
@chrisdholt chrisdholt merged commit 4792832 into feature/fast-frame May 7, 2020
@chrisdholt chrisdholt deleted the users/khamu/fast-frame-site-layout branch May 7, 2020 15:12
radium-v pushed a commit that referenced this pull request May 7, 2020
@khamudom @radium-v
chore: add section layout to the website (#3068)
3f71c53 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 7, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
9a8b3c5 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 8, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
462c96a 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 11, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
2a7bb2e 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 12, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
d66d305 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 13, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
0264c93 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 15, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
2ab8a25 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 18, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
aea4d8c 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
radium-v pushed a commit that referenced this pull request May 18, 2020
@khamudom @radium-v
chore: add section layout to the website (#3068)
0742ddb 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request May 18, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
4d072e4 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
5321880 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
7049f38 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
@khamudom @chrisdholt
chore: add section layout to the website (#3068)
fa48c99 
* add layout to the website

* switch to use fast-anchor. update naming to use BEM. update comment naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radium-v radium-v radium-v approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@janechu janechu janechu approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@eljefe223 eljefe223 Awaiting requested review from eljefe223

Assignees

@khamudom khamudom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khamudom @radium-v @nicholasrice @janechu @chrisdholt