Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create section-header component for marketing site #3070

Merged
merged 8 commits into from
May 8, 2020

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented May 6, 2020

Description

This component is used in the hero section and in every other section down the page.

image

The templates consist of one default slot and three named slots (badge, body and action)

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khamudom let's set this to chore as these are not distributed. If we move these to a package to distribute at some point those can go in as a feature.

Disregard...versioning the site is likely fine.

@khamudom khamudom changed the title feat: create section-header component for marketing site chore: create section-header component for marketing site May 6, 2020
@khamudom khamudom changed the title chore: create section-header component for marketing site feat: create section-header component for marketing site May 6, 2020
@khamudom khamudom force-pushed the users/khamu/section-header-component branch from a9caaaf to b0ba286 Compare May 7, 2020 15:37
@EisenbergEffect EisenbergEffect self-requested a review May 7, 2020 18:35
@radium-v radium-v self-requested a review May 7, 2020 21:02
@eljefe223
Copy link
Contributor

Don't want to drag this PR out but I think the slot naming is confusing I propose this:
image

@chrisdholt
Copy link
Member

chrisdholt commented May 7, 2020

Don't want to drag this PR out but I think the slot naming is confusing I propose this:
image

@eljefe223 is the proposal for everything to have a slot? Based on the current design of the site, I'm inclined to hold fast to to the fact that the Heading is the default thing you would likely want to pass here. I could see body copy being left off in some cases, or an action being left off in some cases. But something should always be the default and the intent of the design seems to be to introduce a section of content, which is why I would hold to the Heading being the default slot.

@eljefe223
Copy link
Contributor

Don't want to drag this PR out but I think the slot naming is confusing I propose this:
image

@eljefe223 is the proposal for everything to have a slot?

That's how it is currently. But the slots name don't match what I would expect them to do. Specifically the default slot being the top smaller heading and the badge slot being the large heading.

@chrisdholt
Copy link
Member

chrisdholt commented May 7, 2020

Don't want to drag this PR out but I think the slot naming is confusing I propose this:
image

@eljefe223 is the proposal for everything to have a slot?

That's how it is currently. But the slots name don't match what I would expect them to do. Specifically the default slot being the top smaller heading and the badge slot being the large heading.

My thought is that we have the following named slots:

  • badge
  • body
  • action

Default slot would be for Heading.

@eljefe223
Copy link
Contributor

Don't want to drag this PR out but I think the slot naming is confusing I propose this:
image

@eljefe223 is the proposal for everything to have a slot?

That's how it is currently. But the slots name don't match what I would expect them to do. Specifically the default slot being the top smaller heading and the badge slot being the large heading.

My thought is that we have the following named slots:

  • badge
  • body
  • action

Default slot would be for Heading.

This also works

@chrisdholt chrisdholt force-pushed the feature/fast-frame branch from 4792832 to 9a8b3c5 Compare May 7, 2020 23:41
@khamudom khamudom force-pushed the users/khamu/section-header-component branch from f1026d5 to fb27458 Compare May 8, 2020 00:09
@khamudom khamudom merged commit 484574b into feature/fast-frame May 8, 2020
@khamudom khamudom deleted the users/khamu/section-header-component branch May 8, 2020 01:54
chrisdholt pushed a commit that referenced this pull request May 8, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request May 11, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request May 12, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request May 13, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request May 15, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
radium-v pushed a commit that referenced this pull request May 18, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
* adding section header component

* add pseudo class part

* rename attribute

* changed short attribute to a <p> tag

* removed attributes to use slots

* Update hero and page section to use section-header component. Removed global background and color style

* changed subheading to badge

* swap default with badge slot. update component implementation on page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants