-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create section-header component for marketing site #3070
feat: create section-header component for marketing site #3070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khamudom let's set this to chore as these are not distributed. If we move these to a package to distribute at some point those can go in as a feature.
Disregard...versioning the site is likely fine.
sites/fast-website/src/app/components/section-header/section-header.template.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/section-header/section-header.template.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/section-header/section-header.template.ts
Show resolved
Hide resolved
sites/fast-website/src/app/components/section-header/section-header.template.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/section-header/section-header.template.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/section-header/section-header.template.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/section-header/section-header.template.ts
Outdated
Show resolved
Hide resolved
a9caaaf
to
b0ba286
Compare
@eljefe223 is the proposal for everything to have a slot? Based on the current design of the site, I'm inclined to hold fast to to the fact that the Heading is the default thing you would likely want to pass here. I could see body copy being left off in some cases, or an action being left off in some cases. But something should always be the default and the intent of the design seems to be to introduce a section of content, which is why I would hold to the Heading being the default slot. |
That's how it is currently. But the slots name don't match what I would expect them to do. Specifically the default slot being the top smaller heading and the badge slot being the large heading. |
My thought is that we have the following named slots:
Default slot would be for Heading. |
This also works |
4792832
to
9a8b3c5
Compare
… global background and color style
f1026d5
to
fb27458
Compare
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
* adding section header component * add pseudo class part * rename attribute * changed short attribute to a <p> tag * removed attributes to use slots * Update hero and page section to use section-header component. Removed global background and color style * changed subheading to badge * swap default with badge slot. update component implementation on page
Description
This component is used in the hero section and in every other section down the page.
The templates consist of one default slot and three named slots (
badge
,body
andaction
)Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist