This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add error handling for bad directory #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I write a test case to cover it too? The generator can simply fail if the directory is missing. |
|
Thank you @shubham1172. Yes, please add a test to cover this functionality. |
|
|
|
Added a test! |
timfpark
approved these changes
Aug 23, 2019
|
Looks good to me - thanks so much for your contribution - its much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #156.
If the directory doesn't exist or the user doesn't have permissions to access it, an error will be logged and returned to the caller.