Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Static component in directory that doesn't exist causes generation to fail. #156

Closed
timfpark opened this issue Apr 22, 2019 · 6 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@timfpark
Copy link
Contributor

When there is a statically generated component, ala:

- name: my-static-component
  generator: "static"
  path: "./my-static-yaml"

and directory my-static-yaml doesn't exist then during generation this causes the generation to fail in a subtle manner such that it is not immediately apparent that there was a failure.

Expected: A normal failure message and non-zero exit code so that CI/CD system can detect that it failed.

@timfpark timfpark added the bug Something isn't working label Apr 22, 2019
@timfpark timfpark added the good first issue Good for newcomers label Apr 29, 2019
@evanlouie evanlouie assigned evanlouie and unassigned evanlouie Apr 29, 2019
@flostadler
Copy link

I'd love to tackle this issue. Any heads up on where to start?

@evanlouie
Copy link
Contributor

hi @flostadler, thanks for taking interest in Fabrikate!

The root of the issue stems from this line: https://github.com/microsoft/fabrikate/blob/master/generators/static.go#L27

Adding some better logging/messaging when the error gets encountered would greatly improve the UX for this flow.

@flostadler
Copy link

Ok, I'm on it

@shubham1172
Copy link
Member

@flostadler, are you still working on it? If not, I can maybe start and write a fix.

@shubham1172
Copy link
Member

@timfpark I guess this can be closed now.

@evanlouie
Copy link
Contributor

Closing. Thanks again @shubham1172 for the contribution :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants