ChoiceSets in Adaptive Cards do not have accessible Names if they don't have a Label #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
guimafelipe,
dkbennett,
EricJohnson327,
AmelBawa-msft and
ssparach
vineeththomasalex
approved these changes
Feb 28, 2024
| namespace DevHome.Common.Renderers; | ||
|
|
||
| public class AccessibleChoiceSet : IAdaptiveElementRenderer | ||
| { |
There was a problem hiding this comment.
Nit: Can add a comment about this being a temp change until AdaptiveCards implements this.
vineeththomasalex
added
the
Needs-Second
EricJohnson327
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
If a
Label(Header) is not specified on aChoiceSet(ComboBox), the resulting ComboBox will not have an accessible name. Creates a custom renderer to render ChoiceSets asAccessibleChoiceSets. If there is no Label, the renderer uses the Placeholder text as the name, if it is available. If not, it renders the ChoiceSet as normal.This workaround is necessary unless Adaptive Cards changes the renderer, see microsoft/AdaptiveCards#8837.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/48294659
https://dev.azure.com/microsoft/OS/_workitems/edit/48181033
Validation steps performed
Tested with ChoiceSets in GitHub and Azure extension widgets.
PR checklist