Environments - Updated UI #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Last Sync timer. Added sorting by name (desc.), alt name (desc.) and last connected (asc.). Fixed sort fields not defaulting back to original values after Sync. Fixed resizing which could cause UI elements to disappear. Changed card style to Primary, Tertiary & Secondary brushes.
huzaifa-d
requested review from
dhoehna,
jsidewhite,
kanismohammed,
AmelBawa-msft and
bbonaby
|
Can you include a screenshot in the PR description? |
krschau
reviewed
Mar 19, 2024
tools/Environments/DevHome.Environments/Strings/en-us/Resources.resw
Outdated
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Outdated
Show resolved
Hide resolved
bbonaby
reviewed
Mar 25, 2024
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Show resolved
Hide resolved
krschau
reviewed
Mar 25, 2024
tools/Environments/DevHome.Environments/Strings/en-us/Resources.resw
Outdated
Show resolved
Hide resolved
krschau
requested changes
Mar 25, 2024
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/ViewModels/ComputeSystemViewModel.cs
Show resolved
Hide resolved
dhoehna
reviewed
Mar 25, 2024
tools/Environments/DevHome.Environments/ViewModels/LandingPageViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
Co-authored-by: Kristen Schau <[email protected]>
krschau
approved these changes
Mar 25, 2024
bbonaby
approved these changes
Mar 26, 2024
krshau's suggestion Co-authored-by: Kristen Schau <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR updates the UI of the Environments page as per updated requirements and to bring it up to parity with the Setup page.
Detailed description of the pull request / Additional comments
Before:
After:
Validation steps performed
Manually tested to check if the UI looks as expected