This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Update HockeyApp IOS SDK to 3.8.5 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version of the sdk supports bitcode
|
LGTM! |
|
I take it we got confirmation that its fixed in the SDK, if so great! So did you upgrade the SDK? If so, did you also make sure the symlinks are blown out to files in the plugin? (I can't tell very well from the PR.) |
|
BTW - An alternate solution here that would prevent you from having to blow out the contents of the symlinks under sub-folders would be to add a hook with my symlink reconstruction code in it. This is what Sergey did in a PR to the Facebook Connect plugin. That can help on Windows with the max path limit. See Wizcorp/phonegap-facebook-plugin#1022 |
|
Looks like when i unzipped the SDK on linux, it filled in the symlinks for me, so this is taken care of already. Thanks Chuck! |
ryuyu
added a commit
that referenced
this pull request
Jan 27, 2016
Update HockeyApp IOS SDK to 3.8.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the bitcode warnings as this version of the sdk supports bitcode.
@dlevine82 @Chuxel @lostintangent