Restore symlinks in FacebookSDK.Framework before build #1022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hooks for save/restore symlinks metadata. This fixes issue when iOS custom frameworks is being broken when plugin installed from CPR/NPM. See https://issues.apache.org/jira/browse/CB-6092 for details
Save is being performed each time, plugin is being packaged or published through NPM. Restore - each time when iOS project is being compiled.
Quirks:
package.json
while publishing plugin to CPR and thus doesn't execprepublish
script, the generated symlinks metadata already included in this PR. It could be also generated manually by runningnpm run prepublish
inside of plugin directory.before_compile
hook is available in cordova@>=4.0.0 only so the symlinks won't be restored in earlier versions of cordova.