Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK depends on Angular even when used in pure Node.js #403

Closed
compulim opened this issue Jul 15, 2021 · 1 comment · Fixed by #408
Closed

SDK depends on Angular even when used in pure Node.js #403

compulim opened this issue Jul 15, 2021 · 1 comment · Fixed by #408
Assignees

Comments

@compulim
Copy link
Contributor

When installing microsoft-cognitiveservices-speech-sdk, it said @angular/common>=5 is required.

  compulim@ubuntu:/tmp/speech$ npm i microsoft-cognitiveservices-speech-sdk
  npm WARN saveError ENOENT: no such file or directory, open '/tmp/speech/package.json'
  npm notice created a lockfile as package-lock.json. You should commit this file.
  npm WARN enoent ENOENT: no such file or directory, open '/tmp/speech/package.json'
- npm WARN [email protected] requires a peer of @angular/common@>= 5.0.0 but none is 
  installed. You must install peer dependencies yourself.
- npm WARN [email protected] requires a peer of @angular/core@>= 5.0.0 but none is 
  installed. You must install peer dependencies yourself.
  npm WARN speech No description
  npm WARN speech No repository field.
  npm WARN speech No README data
  npm WARN speech No license field.

  + [email protected]
  added 45 packages from 42 contributors and audited 45 packages in 2.8s

  7 packages are looking for funding
    run `npm fund` for details

  found 0 vulnerabilities

I think should either specify the peer deps in package.json, or not requiring Angular.

If the SDK can be targeted to headless environment (a.k.a. on Node.js and not browser), Angular should not be a requirement. But in fact, it is.

The scenario will be worsened as npm@7 will automatically install all missing peer dependencies. Using this SDK in a pure Node.js environment will need to install/run Angular.

@glharper glharper self-assigned this Jul 15, 2021
glharper added a commit that referenced this issue Jul 27, 2021
#403 (#408)

* Replace xmlhttprequest-ts dependency with bent, clean up code

* code cleanup
@glharper
Copy link
Member

glharper commented Aug 9, 2021

@compulim Version 1.18.1 of the JS Speech SDK has been released with a fix for this issue. Thanks again for reporting it, and using Speech SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants