Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.14.2 Release checklist #4409

Closed
74 tasks done
compulim opened this issue Sep 7, 2022 · 0 comments
Closed
74 tasks done

4.14.2 Release checklist #4409

compulim opened this issue Sep 7, 2022 · 0 comments
Assignees
Labels
release Release checklist

Comments

@compulim
Copy link
Contributor

compulim commented Sep 7, 2022

Checklist

Build

  1. Bump MockBot to Bot Framework SDK release 4.15.3 (not needed for patch release)
  2. Bump botframework-directlinejs to x.y.z (no newer version)
  3. Bump to 4.14.2
  4. Run daily pipeline manually, set "generate release version number" to true
    • (This will not push to NPM or CDN)
    • Pipeline name is BotFramework-WebChat-daily
    • The build number is 320565 and commit is 1200c38
  5. Wait for WebChat-release-testing pipeline to complete
    • Pipeline name is Push-Release-Testing-to-GitHub-Pages
    • The release ID is 421
  6. Check component governance and make sure there are no high/critical related to code under /packages/ folder
    • There could be some for projects under /samples/ folder, as they are pointing to previous version of Web Chat
  7. Add manual tests to WebChat-release-testing as needed

Test

The test should run against the build artifacts from Azure Pipelines.

  1. Manual testing on major browsers using webchat-release-testing
    • Before starting testing, update all the browser version to latest
    • Chrome 105.0.5195.102
    • Edge 107.0.1375.0
    • Firefox 104.0.1
    • IE11 (Windows 11 22H2 22622.590)
    • macOS Safari 15.5 (17613.2.7.1.8)
    • iOS Safari 15.6.1
    • Android Chrome 104.0.5112.97
  2. Test specific fixes related to 4.14.2 and previous releases
    • Test uploading a file while in Polish

Release

  1. Verify on WebChat-release-testing
  2. Make sure you are on qfe-4.14.1 branch, run git status to check
  3. git pull
  4. Verify /package.json, /package-lock.json, and CHANGELOG.md has a version of 4.14.2
  5. git log
    • Verify the latest commit is 1200c38
  6. git tag v4.14.2
  7. git push -u upstream v4.14.2
    • You do not need to kick off a build again, use the previous build
  8. Create a new GitHub release, copy entries from CHANGELOG.md
    • Subresource Integrity can be generated by
      • From local: cat webchat.js | openssl dgst -sha384 -binary | openssl base64 -A
      • From CDN: curl -H 'Accept-Encoding: gzip' https://cdn.botframework.com/botframework-webchat/4.15.3/webchat.js | gunzip - | openssl dgst -sha384 -binary | openssl base64 -A
    • Attach assets including 3 JS files, stats.json and 5 tarballs
      • You can copy the artifacts from webchat-release-testing/drops
      • Tarballs download from npmjs
        curl -LO https://registry.npmjs.org/botframework-directlinespeech-sdk/-/botframework-directlinespeech-sdk-4.15.3.tgz
        curl -LO https://registry.npmjs.org/botframework-webchat/-/botframework-webchat-4.15.3.tgz
        curl -LO https://registry.npmjs.org/botframework-webchat-core/-/botframework-webchat-core-4.15.3.tgz
        curl -LO https://registry.npmjs.org/botframework-webchat-api/-/botframework-webchat-api-4.15.3.tgz
        curl -LO https://registry.npmjs.org/botframework-webchat-component/-/botframework-webchat-component-4.15.3.tgz
        
  9. Kick off release to NPM
    • Release name is [[PROD]]Push-WebChat-to-npmjs
    • The build number is 320565 release number is 41 and commit is 1200c38
    • Verify package content then click Resume
    • Retain the release indefinitely
  10. Kick off release to CDN (cutoff at 2PM PST, Mon-Thu only)
    1. Prepare message for approval
      • If there are any breaking changes, explain in the email if it will affect any customers
      • Release name is [[PROD]]Push-WebChat-to-Prod-CDN-with-approval
      • The build number is 320565, release number is 45 and commit is 1200c38
      • Script build number is 320584 of 10ffab05 (this is fixed)
    2. Send message to approvers
    3. Retain the build indefinitely

Post-release verification - complete within 30 minutes after release to NPM

  • Test using webchat-release-testing
    1. Clone https://github.com/corinagum/WebChat-release-testing/
    2. 01.create-react-app
      1. Nuke 01.create-react-app/node_modules
      2. npm install
      3. npm install [email protected] (just install the bundle package)
      4. npm run build
    3. Others
      • Using script tags from https://github.com/microsoft/BotFramework-WebChat/releases/tag/v4.14.2, with subresource integrity
        <script
          crossorigin="anonymous"
          integrity_no="sha384-TX+6Xqq20HcCfn9vFBfivPrnGantvLj6bVoeZMiRt3TDf7QL0l3y0h5NfXPHeMYD"
          src="https://cdn.botframework.com/botframework-webchat/4.14.2/webchat.js"
        ></script>
        
        <script
          crossorigin="anonymous"
          integrity_no="sha384-rICoECir+m94sA3D9FN2nWP76JKfcGJA5uhCZ/nSM3JNYWtnqUk5mHCgVvgWE+if"
          src="https://cdn.botframework.com/botframework-webchat/4.14.2/webchat-es5.js"
        ></script>
        
        <script
          crossorigin="anonymous"
          integrity_no="sha384-FDtL64x1C0SfN3jynhpEExETYworgZHfADHx+04wRT4RGxeXQulwMv7u9s8gUkkZ"
          src="https://cdn.botframework.com/botframework-webchat/4.14.2/webchat-minimal.js"
        ></script>
        
    4. npx serve (at repo root)
    5. Go to http://localhost:5000/ to test, including IE11

Notification to interested parties


Post-release checklist

These are chores that we should do before starting the cycle to reduce ripple effects if we do it in mid-cycle.

Tips:

  • Clean your repo before start
  • Remove node_modules from all folder
    • git clean -fdx
  • Never delete package-lock.json
  • If you mess it up, tableflip and redo
  • In component/package.json
    • Remove reference to botframework-webchat-core by hand-modifying package.json
    • Then, npm install (symlinks will be broken afterward)
    • Then, add those references back by hand-modifying package.json
    • This also applies for other packages with similar dependencies/symlinks
    • To build afterward, do tableflip to rebuild those symlinks

Applies to all releases

This list should be copied to versions in the future.

Applies to major/minor releases

Bump all dependencies to latest version

(Not needed for QFE)

In PR #4392, we are bumping most dependencies to latest version.

After bumping, if a package broke compatibility, we should investigate:

  • Upgrade our code to use the latest package if possible, otherwise;
  • Add it to package.json/skipBump to prevent bumping deliberately:
    • Skipping bump incur unpredictable technical debts, say, security issue found in the unsupported version, causing us slow to react
    • Plausible reasons (non-exhaustive):
      • Package is not ES5;
      • Package is ESM and requires the whole dependency chain to be upgraded, however, it is technically impossible (unrelated to cost).
  • Run npm run bump
  • Run npm audit fix to make sure everything is fixed
  • Test under IE11 to make sure all dependencies are working
  • List steps to verify bumping microsoft-cognitiveservices-speech-sdk

Obstacles to bump npm

Check if the followings are still valid. We should bump to npm@latest ([email protected]) as soon as possible.

As of writing, [email protected] (bundled by node@16) has issue on running postinstall script.

[email protected] is peer-depends on @angular/common, which npm@7 will automatically install missing peer dependencies. Track the issue here.

@compulim compulim added the release Release checklist label Sep 7, 2022
@compulim compulim self-assigned this Sep 7, 2022
@compulim compulim changed the title Release checklist of 4.14.2 4.14.2 Release checklist Sep 7, 2022
@compulim compulim closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release checklist
Projects
None yet
Development

No branches or pull requests

1 participant